Skip to content

Auto remove trailing whitespace with pre-commit - #14288

Open
jbampton wants to merge 2 commits into
apache:mainfrom
jbampton:remove-trailing-whitespace
Open

jbampton wants to merge 2 commits into
apache:mainfrom
jbampton:remove-trailing-whitespace

Conversation

@jbampton

@jbampton jbampton commented Oct 1, 2026

Copy link
Copy Markdown
Member

https://github.com/pre-commit/pre-commit-hooks#trailing-whitespace

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copilot AI balanced review requested due to automatic review settings October 1, 2026 15:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The filter change is correct and the legal-file edits only remove trailing whitespace.

Review effort: Balanced
Findings: None

What changed in this PR

Expands trailing-whitespace enforcement to nested license and notice files and cleans existing violations.

Changes:

  • Broadens the pre-commit filename filter.
  • Removes trailing whitespace from Whisker legal files.
File Description
.pre-commit-config.yaml Includes nested LICENSE, NOTICE, and README files.
tools/​whisker/​LICENSE Removes trailing whitespace.
tools/​whisker/​NOTICE Removes trailing whitespace.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.77%. Comparing base (c5bd11a) to head (3ff8b5e).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14288      +/-   ##
============================================
- Coverage     20.77%   20.77%   -0.01%     
  Complexity    20855    20855              
============================================
  Files          6053     6053              
  Lines        548230   548230              
  Branches      73237    73237              
============================================
- Hits         113903   113902       -1     
  Misses       420988   420988              
- Partials      13339    13340       +1     
Flag Coverage Δ
uitests 3.86% <ø> (ø)
unittests 22.21% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, I doubt that tools/whisker is still used

@jbampton
jbampton requested a review from vishesh92 November 11, 2026 11:49
Copilot AI balanced review requested due to automatic review settings November 15, 2026 09:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the whitespace-hook expansion and Whisker license and notice cleanup.

No open issues 🎉

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants