Skip to content

Fix VR additional public NICs being plugged with link state down - #14724

Open
hsato03 wants to merge 1 commit into
apache:mainfrom
scclouds:fix-vr-nic-link-state-down
Open

hsato03 wants to merge 1 commit into
apache:mainfrom
scclouds:fix-vr-nic-link-state-down

Conversation

@hsato03

@hsato03 hsato03 commented Nov 18, 2026

Copy link
Copy Markdown
Member

Description

Since 4.23.0.0, BridgeVifDriver sets the interface link state based on the enabled field of NicTO. However, the NicTO of the additional public NICs of the VR was sent to the agent with enabled=false, so these interfaces were plugged with link state DOWN. This PR changes the default value of the enabled field of NicTO to true, so they are plugged with link state UP.

Fixes: #14463

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

In a KVM environment with two public IP ranges (untagged and vlan://333), I acquired an IP from the second VLAN for an isolated network and enabled Static NAT to a VM. The new VR NIC was plugged with link state UP (virsh domif-getlink). The same was verified after disabling/re-enabling Static NAT and after changing the source NAT IP.

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.86%. Comparing base (278bde2) to head (4f85da4).
⚠️ Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (278bde2) and HEAD (4f85da4). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (278bde2) HEAD (4f85da4)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               main   #14724       +/-   ##
=============================================
- Coverage     20.78%    3.86%   -16.92%     
=============================================
  Files          6053      494     -5559     
  Lines        548230    42875   -505355     
  Branches      73237     8136    -65101     
=============================================
- Hits         113928     1657   -112271     
+ Misses       420955    40986   -379969     
+ Partials      13347      232    -13115     
Flag Coverage Δ
uitests 3.86% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4.23.0.0 KVM: virtual router NIC for a public IP on a second VLAN comes up with link state down

1 participant