Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #14724 +/- ##
=============================================
- Coverage 20.78% 3.86% -16.92%
=============================================
Files 6053 494 -5559
Lines 548230 42875 -505355
Branches 73237 8136 -65101
=============================================
- Hits 113928 1657 -112271
+ Misses 420955 40986 -379969
+ Partials 13347 232 -13115
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since 4.23.0.0,
BridgeVifDriversets the interface link state based on theenabledfield ofNicTO. However, theNicTOof the additional public NICs of the VR was sent to the agent withenabled=false, so these interfaces were plugged with link stateDOWN. This PR changes the default value of theenabledfield ofNicTOtotrue, so they are plugged with link stateUP.Fixes: #14463
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
In a KVM environment with two public IP ranges (
untaggedandvlan://333), I acquired an IP from the second VLAN for an isolated network and enabled Static NAT to a VM. The new VR NIC was plugged with link stateUP(virsh domif-getlink). The same was verified after disabling/re-enabling Static NAT and after changing the source NAT IP.How did you try to break this feature and the system with this change?