Repository navigation
Fix grammar, spelling, word casing, whitespace - #9132
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9132 +/- ##
=========================================
Coverage 20.77% 20.77%
+ Complexity 20855 20853 -2
=========================================
Files 6053 6053
Lines 548230 548230
Branches 73237 73237
=========================================
+ Hits 113903 113918 +15
+ Misses 420988 420963 -25
- Partials 13339 13349 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
DaanHoogland
left a comment
There was a problem hiding this comment.
I immagine I missed a few, and in dutch (intended mistake) these would be considered shouting, but for consistency some sugestions...
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
…ployVMCmd.java Co-authored-by: dahn <daan.hoogland@gmail.com>
…ployVMCmd.java Co-authored-by: dahn <daan.hoogland@gmail.com>
Co-authored-by: dahn <daan.hoogland@gmail.com>
Co-authored-by: dahn <daan.hoogland@gmail.com>
…ache/cloudstack/network/contrail/management/ServiceManagerImpl.java Co-authored-by: dahn <daan.hoogland@gmail.com>
…/commands/StopNetScalerVMCmd.java Co-authored-by: dahn <daan.hoogland@gmail.com>
Co-authored-by: dahn <daan.hoogland@gmail.com>
|
@blueorangutan package |
|
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11340 |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11418 |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
Hi @jbampton can you please fix the conflicts? |
Stop talking, do some work... Co-authored-by: João Jandre <48719461+JoaoJandre@users.noreply.github.com>
Resolve conflicts by keeping the wording and code from main where both sides changed the same lines. Re-apply the casing fixes from this PR that main still needed: - 'id' to 'ID' in six messages in UserVmManagerImpl - 'Instance Id' to 'Instance ID' in NetworkServiceImpl - 'Vm ID' to 'VM ID' in TemplateManagerImpl
There was a problem hiding this comment.
🟡 Changes recommended
The VM-start error message lacks a space after the added period, joining two messages together, and the revised shell comment remains grammatically incorrect.
1 open issue
What changed in this PR
This PR improves wording and terminology consistency across CloudStack’s VM management code, integration tests, and setup scripts without changing control flow.
Changes:
- Standardizes acronym casing in logs, exception messages, event descriptions, and comments.
- Corrects spelling, grammar, and whitespace in comments and test messages.
- Updates a unit-test expectation to match the revised NAT exception message.
| File | Description |
|---|---|
test/integration/component/test_netscaler_lb.py |
Cleans up test comments and diagnostic messages. |
test/integration/component/maint/test_host_high_availability.py |
Corrects comment spacing, docstrings, and assertion messages. |
systemvm/debian/opt/cloud/bin/setup/common.sh |
Corrects spelling in setup comments. |
server/src/test/java/com/cloud/vm/UserVmManagerTest.java |
Standardizes VM ID casing in commented-out code only. |
server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java |
Aligns the expected exception message with NAT casing. |
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java |
Standardizes messages, event descriptions, and comments. |
server/src/main/java/com/cloud/template/TemplateManagerImpl.java |
Standardizes VM casing in ISO-detachment event details. |
server/src/main/java/com/cloud/network/NetworkServiceImpl.java |
Standardizes ID casing in a log message. |
plugins/network-elements/stratosphere-ssp/src/test/java/org/apache/cloudstack/network/element/SspElementTest.java |
Corrects spelling and API casing in comments only. |
plugins/network-elements/juniper-contrail/src/main/java/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java |
Standardizes VM ID casing in event details. |
framework/db/src/main/java/com/cloud/utils/db/EcInfo.java |
Corrects spelling in an assertion message. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
resolved, merging if CI turns green |
|
2 LGTMS, CI passing (the single failure caused by test/integration/component/est_mm_domain_limits.py, which this PR does not touch - as advised by Copilot) No Marvin tests needed. @JoaoJandre @FelipeM525 the requested changes were applied: casing is now consistently “VM ID” / “ID” throughout, and conflicts with main are resolved. Merging on that basis. |

Description
This PR cleans up the code base and standardizes some terms for casing.
Fixes in exception messages, log messages, code comments and more.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?