Repository navigation
Conversation
Points the DataFusion workspace dependencies at the 56.0.0-rc2 git tag to validate the release candidate, bumps arrow to 60 and object_store to 0.14 to match, and adapts to upstream API changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A — validates the DataFusion 56.0.0 release candidate against this binding.
Rationale for this change
Tests the binding against
56.0.0-rc2ahead of the release, so any breakage gets reported upstream during the vote and the final 56.0.0 bump is just a version change. Draft: this depends on a git tag and should not merge in this form. Once 56.0.0 is published, the git deps go back to crates.io versions.What changes are included in this PR?
datafusion,datafusion-proto,datafusion-sparkanddatafusion-substraitnow point atgit = "https://github.com/apache/datafusion", tag = "56.0.0-rc2".arrowmoves from 59 to 60 andobject_storefrom 0.13 to 0.14, matching what DataFusion 56 pulls in.<datafusion.version>is set to56.0.0-rc2, so the.protofiles are downloaded from the same tag. Both<sha512>digests are updated.Changes needed for the upstream API changes:
TableProvider::scantakesOption<&[usize]>for the projection, notOption<&Vec<usize>>.JavaTableProvideris updated to match.ParquetOptions.compressionis nowOption<DFParquetCompression>, not aString.writeParquetparses the caller's string withDFParquetCompression::from_str. A side effect: an invalid codec or level is now rejected before writing starts, with aConfigurationerror, instead of failing when the first file is written.ArrowArrayStreamReaderwas renamed toRecordBatchStreamReaderin arrow 60. The old name is a deprecated alias, and it would failclippy -D warnings.Are these changes tested?
Covered by the existing suites:
./mvnw test: 349 tests, 0 failures, 13 skipped (TPC-H data-gated tests; no local TPC-H data).cargo test --workspace --features substrait,spark: passing.cargo clippy --all-targets --workspace --features substrait,spark -- -D warnings: clean.cargo fmt --alland./mvnw spotless:apply: clean.Are there any user-facing changes?
An invalid Parquet compression string passed to
writeParquetnow fails earlier, at configuration time. Otherwise there are no API changes.🤖 Generated with Claude Code