Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #26528.
Rationale for this change
TRY_CASTrejects struct casts at planning time thatCASTaccepts, such as when the target has an additional nullable field.What changes are included in this PR?
can_plan_casthelper used by bothCASTandTRY_CAST.ColumnarValue::cast_to.What is the testing strategy for this PR?
Added regression cases to
struct.sltcovering missing fields, failed casts returning NULL, lists of structs, and structs with no matching field names still failing at planning time.The positive cases fail on main and pass with this fix.
Are there any user-facing changes?
TRY_CASTnow accepts additional valid struct casts. No public API changes.Remaining questions
This also moves CAST's two inline checks into the shared helper to prevent the paths from drifting apart. Happy to limit the change to
TRY_CASTif preferred.