Repository navigation
Core: Load and serialize nanosecond timestamp defaults - #4462
Open
Anurag-S1ngh wants to merge 1 commit into
Open
Anurag-S1ngh wants to merge 1 commit into
Anurag-S1ngh wants to merge 1 commit into
Conversation
JSON single-value conversion had no handler for timestamp_ns and timestamptz_ns, so loading a V3 metadata file with a nanosecond default raised TypeError. Python datetime cannot hold nanoseconds, so parse these values as nanoseconds since epoch and format them back with nine fractional digits.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4078.
Rationale for this change
JSON single-value conversion had no handler for
timestamp_nsandtimestamptz_ns, so loading a V3 metadata file with a nanosecondinitial-defaultraisedTypeError: Cannot deserialize bytes, type timestamp_ns not supported.Python
datetimecannot hold nanoseconds, so these values are parsed as nanoseconds since epoch and formatted back as ISO-8601 with nine fractional digits. This preserves the exact value instead of truncating to microseconds.Are these changes tested?
Yes. The JSON conversion tests cover formatting, round trips, and parsing for both nanosecond types, including values supplied as
datetimewhere the last three digits are zero. A field default test confirms that a nanosecondinitial-defaultloads as an integer and serializes back unchanged.tests/test_conversions.pyandtests/test_types.pypass.Are there any user-facing changes?
No API change. V3 metadata with nanosecond timestamp defaults can now be loaded and serialized.