Repository navigation
Conversation
Users who log in through LDAP or the servlet container have users.passwords.externalAuthValue stored in place of a Roller password. Roller's password encoder no longer matches that placeholder, so it isn't treated as a password anywhere the encoder checks one.
snoopdave
reviewed
Nov 18, 2026
…match an empty one Registration, the profile page and the admin user editor now reject users.passwords.externalAuthValue, and the default <externalAuth>, as a new password with a validation message, since that value never matches at login. An account that already has it can be given a new password by an administrator. An empty configured value now falls back to <externalAuth> for what Roller stores, and the password encoder never matches an empty password or the default placeholder.
…n-placeholder-6.1.x
Contributor
Author
|
A second review raised a few more points, now addressed in the latest commits:
|
snoopdave
reviewed
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 6.1.x version of #304.
Users who log in through LDAP or the servlet container have
users.passwords.externalAuthValue(by default<externalAuth>) stored in place of a Roller password.RollerContextnow wraps its password encoder in a newExternalLoginAwarePasswordEncoder, whosematches()never accepts that placeholder, the default<externalAuth>or an empty password, wherever Roller checks a password with the encoder. Encoding andupgradeEncodingare unchanged, and stored passwords aren't touched.As on #304, registration, the profile page and the admin user editor refuse the placeholder as a new password, and an empty
users.passwords.externalAuthValuefalls back to<externalAuth>.This line builds for Java 11, so the wrapper is a class rather than the record #304 uses, and
RollerContext.encoderis now typed asPasswordEncoder.ExternalLoginAwarePasswordEncoderTestchecks that the placeholder doesn't match, encoded or unencoded, and that other passwords (bcrypt and plaintext) still do.ExternalLoginPlaceholderTestchecks the placeholder encoded and unencoded, the default placeholder under another configured value, an empty configured value and an ordinary password, andExternalLoginMarkerPasswordTestchecks that registration, the profile page and the admin user editor refuse the placeholder.mvn testpasses.