Repository navigation
Conversation
The profile and registration forms no longer set User.openIdUrl, which holds the issuer#subject that an OIDC login uses to find its account. Only Roller's OIDC login code sets it. Profile.save uses the stored value for its checks, whatever the request carries, so OIDC and DB_OIDC users still save their profiles; Register ignores it; and the profile page no longer posts it as a hidden field.
…resigning Declining a weblog invitation now removes the permission only while it is still pending, so it can no longer remove an accepted membership. Resigning from a weblog is refused, with a message, when the user is the weblog's only admin; pending invitations do not count as another admin.
…bind name LdapCommentAuthenticator now escapes the submitted user name with Rdn.escapeValue before putting it in the uid part of the bind DN, so characters such as commas, plus signs and equals signs stay part of the user name.
…ing nothing WeblogSearchRequest and WeblogFeedRequest now keep only the first 256 characters of the q parameter, without splitting a surrogate pair. SearchOperation now catches runtime exceptions that Lucene throws for queries that parse but cannot be built or run, such as an unfinished regular expression or a negative phrase slop. It logs them as a warning and handles them the same way as a query that does not parse.
This was referenced Nov 18, 2026
snoopdave
reviewed
Nov 18, 2026
…ed operation Resigning from a weblog and saving the Members page now go through UserManager.updateWeblogMembership(), which locks the weblog's row, reads its memberships again, and applies the changes in the same transaction only if an enabled administrator remains. Concurrent membership changes for a weblog therefore run one after the other and can't leave it without an administrator, and a disabled user who holds ADMIN no longer counts as one.
Removing a weblog or a user now also removes its pending invitations, so a weblog or user created later with the same name doesn't inherit them.
When the 256-character limit ends inside a quoted phrase, the search and feed requests now drop that phrase's opening quote, so the rest of the query still parses and finds entries instead of nothing.
Contributor
Author
|
A second review raised a few more points, now addressed in the latest commits:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four smaller fixes:
Profile.savekeeps the storedopenIdUrl(the OIDCissuer#subRoller uses to find an account at OIDC login),ProfileBean.copyTono longer writes it,Register.saveno longer takes it from the form, and the hidden field is gone fromProfile.jsp. Only Roller's OIDC code sets it now. AdminUserEditis unchanged. Test:FederatedIdentityFormTest.yourWebsites.resign.lastAdmin). Resigning and saving the Members page go through a newUserManager.updateWeblogMembership(), which locks the weblog's row, reads its memberships again and applies the changes in the same transaction only if an enabled administrator remains, so concurrent changes run one after the other and can't leave a weblog without an administrator, and a disabled user with ADMIN doesn't count as one. Removing a weblog or a user also removes its pending invitations, so a weblog or user created later with the same name doesn't inherit them. Tests:WeblogMembershipTest, new cases inPermissionTest.javax.naming.ldap.Rdn.escapeValuebefore it goes into the bind DN. Test: new cases inLdapCommentAuthenticatorTest.q) is capped at 256 characters, without splitting a surrogate pair, in search and feed requests. When the cap ends inside a quoted phrase, that phrase's opening quote is dropped so the rest of the query still parses.SearchOperationtreats any runtime exception while parsing or searching as a query error: no results, a logged warning. Tests:SearchMalformedQueryTest,SearchQueryLengthTest.mvn testpasses, and the Playwright database-login suite passes (20 run, 3 OIDC tests skipped).CHANGES entries for this and the related fixes will come in one PR.