Skip to content

Say when a typed password is too long, and keep the generated one out of the form - #343

Open
mraible wants to merge 7 commits into
masterfrom
password-length-checks
Open

mraible wants to merge 7 commits into
masterfrom
password-length-checks

Conversation

@mraible

@mraible mraible commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #304, so merge #304 first; until then this PR's diff includes its commits.

Follows up #323 from review.

  • A password over 72 bytes in UTF-8 (for example 20 emoji) made BCrypt throw when registration, the profile page or the admin user editor saved it, so the user got an error page. The forms now check the length first, with the new RollerPasswordEncoders.isTooLong, and say the password is too long (userRegister.error.passwordTooLong). The profile page checks it whether or not an OpenID URL is given, since it saves a typed password either way.
  • Registration put the random password it generates for OIDC users in the form's hidden password fields, so a registration that failed validation, for example on a taken user name, sent it back to the browser. It now keeps that password in the action and uses it only when saving the user.

Tests: PasswordFormValidationTest covers registration and the profile page (with and without an OpenID URL), a password at the limit, and the generated password staying out of the form; UserEditPasswordLengthTest covers the admin user editor.

Users who log in through LDAP or the servlet container have users.passwords.externalAuthValue stored in place of a Roller password. Roller's password encoder no longer matches that placeholder, so it isn't treated as a password anywhere the encoder checks one.
…match an empty one

Registration, the profile page and the admin user editor now reject users.passwords.externalAuthValue, and the default <externalAuth>, as a new password with a validation message, since that value never matches at login. An account that already has it can be given a new password by an administrator. An empty configured value now falls back to <externalAuth> for what Roller stores, and the password encoder never matches an empty password or the default placeholder.
… of the form

A password over 72 bytes in UTF-8, for example 20 emoji, made BCrypt throw when Register, Profile or UserEdit saved it, so the user got an error page. The forms now check the length first and say the password is too long.

Register also put the random password it generates for OIDC users in the form's hidden password fields, so a registration that failed validation, for example on a taken user name, sent it back to the browser. It now keeps that password in the action and only uses it when saving the user.
Profile only checked a typed password's length when no OpenID URL was given, but it saves a typed password either way, so a long one with an OpenID URL still failed in BCrypt.
@mraible
mraible changed the base branch from external-login-placeholder to master November 18, 2026 04:14
@mraible
mraible requested a review from snoopdave November 18, 2026 04:16
@mraible mraible closed this Nov 18, 2026
@mraible mraible reopened this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants