Skip to content

Upgrade the admin UI to jQuery 4.1.0 and drop jQuery from the Gaurav theme - #348

Open
mraible wants to merge 2 commits into
masterfrom
jquery-4.1.0
Open

mraible wants to merge 2 commits into
masterfrom
jquery-4.1.0

Conversation

@mraible

@mraible mraible commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

jQuery 4.1.0 and 3.8.0 came out on 2026-11-17 with a fix for a ReDoS in selector identifier matching: a long chain of escapes followed by an invalid character could hang the page.

  • The admin UI moves from the jQuery 4.0.0 webjar to 4.1.0.
  • The Gaurav theme no longer loads jQuery or Bootstrap's JavaScript. Bootstrap 3's JavaScript refuses to run with jQuery 4, and the theme used it only for the navbar's collapse button and Categories dropdown. A small script, js/navbar.js, now toggles the same Bootstrap 3 CSS classes and aria-expanded, and closes the dropdown on an outside click or Escape. The theme keeps Bootstrap 3.4.1's CSS, so it looks the same.
  • With that, the admin UI's jQuery 4.1.0 is the only jQuery left in Roller.
  • LICENSE, the binary LICENSE and CHANGES are updated.

I checked navbar.js with the theme's Bootstrap CSS and its navbar markup at 390px and 1280px wide. The phone menu opens and closes, and the dropdown opens, closes again, and closes on an outside click and on Escape, with no script errors.

Weblogs that customized the theme keep their own copies of the old files. The 6.1.x changes are in #349 and #350.

jQuery 4.1.0 and 3.8.0, released on 2026-11-17, fix a ReDoS in selector identifier matching, where a long chain of escapes followed by an invalid character could hang the page.

The admin UI moves from the jQuery 4.0.0 webjar to 4.1.0. The Gaurav theme's bundled jquery.js moves from 3.7.1 to 3.8.0, the unmodified jquery.min.js from the npm package (integrity checked), so the theme's Bootstrap 3 plugins keep the 3.x API. LICENSE, the binary LICENSE and CHANGES name the new versions.
@mraible
mraible requested a review from snoopdave November 18, 2026 14:14
Bootstrap 3's JavaScript refuses to run with jQuery 4, and the theme used it only for the navbar's collapse button and Categories dropdown. A small script, js/navbar.js, now toggles the same Bootstrap 3 CSS classes (in and open) and aria-expanded, closes the dropdown on an outside click or Escape, and needs no library. jquery.js and bootstrap.js are removed from the theme, its theme.xml and the LICENSE files, so the admin UI's jQuery 4.1.0 is the only jQuery left in Roller. The theme keeps Bootstrap 3.4.1's CSS, so it looks the same.

Weblogs that customized the theme keep their own copies of the old files.
@mraible mraible changed the title Upgrade jQuery to 4.1.0 and the Gaurav theme's jQuery to 3.8.0 Upgrade the admin UI to jQuery 4.1.0 and drop jQuery from the Gaurav theme Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant