Skip to content

Keep the enabled comment plugins checked in Server Admin > Configuration - #354

Open
mraible wants to merge 1 commit into
masterfrom
keep-comment-plugins
Open

mraible wants to merge 1 commit into
masterfrom
keep-comment-plugins

Conversation

@mraible

@mraible mraible commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

The comment plugin checkbox list on Server Admin > Configuration set value="name", which doesn't evaluate to the enabled plugin ids. Every box showed unchecked, even HTMLSubset, the default. Saving the page for any reason then stored an empty users.comments.plugins, which turned off HTMLSubset and every other comment plugin site-wide.

  • On master and roller-6.1.x, HTML comments are escaped when HTMLSubset doesn't run, so they showed as escaped markup.
  • In 6.1.7, which escapes only text/plain comments, HTML comments were shown unfiltered once HTML comments were allowed.

Without the value attribute, the list checks the plugins in commentPlugins, which the action loads from users.comments.plugins. The bug dates from e83e5f8 (2018).

NewUserJourneyIT saves this page to enable uploads. It now checks that HTMLSubset is checked before and after the save. It failed before the fix (HTMLSubset unchecked on a fresh site) and passes after; the db-mode UI suite passes (20 tests, the 3 OIDC tests skipped).

The 6.1.x fix is a separate PR.

The comment plugin checkbox list set value="name", which doesn't evaluate to the enabled plugin ids, so every box showed unchecked. Saving the page then stored an empty plugin list, which turned off HTMLSubset, the default comment plugin, and every other comment plugin site-wide. HTML comments were then shown escaped. Without the value attribute, the list checks the plugins in commentPlugins, which the action loads from users.comments.plugins.

NewUserJourneyIT saves the page to enable uploads and now checks that HTMLSubset is checked before and after the save.
@mraible
mraible requested a review from snoopdave November 18, 2026 17:38

@snoopdave snoopdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants