Repository navigation
Conversation
The comment plugin checkbox list set value="name", which doesn't evaluate to the enabled plugin ids, so every box showed unchecked. Saving the page then stored an empty plugin list, which turned off HTMLSubset, the default comment plugin, and every other comment plugin site-wide. HTML comments were then shown escaped. Without the value attribute, the list checks the plugins in commentPlugins, which the action loads from users.comments.plugins. NewUserJourneyIT saves the page to enable uploads and now checks that HTMLSubset is checked before and after the save.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment plugin checkbox list on Server Admin > Configuration set
value="name", which doesn't evaluate to the enabled plugin ids. Every box showed unchecked, even HTMLSubset, the default. Saving the page for any reason then stored an emptyusers.comments.plugins, which turned off HTMLSubset and every other comment plugin site-wide.Without the
valueattribute, the list checks the plugins incommentPlugins, which the action loads fromusers.comments.plugins. The bug dates from e83e5f8 (2018).NewUserJourneyIT saves this page to enable uploads. It now checks that HTMLSubset is checked before and after the save. It failed before the fix (HTMLSubset unchecked on a fresh site) and passes after; the db-mode UI suite passes (20 tests, the 3 OIDC tests skipped).
The 6.1.x fix is a separate PR.