Skip to content

Keep the enabled comment plugins checked in Server Admin > Configuration - #355

Merged
mraible merged 1 commit into
roller-6.1.xfrom
keep-comment-plugins-6.1.x
Nov 18, 2026
Merged

mraible merged 1 commit into
roller-6.1.xfrom
keep-comment-plugins-6.1.x

Conversation

@mraible

@mraible mraible commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

The comment plugin checkbox list on Server Admin > Configuration set value="name", which doesn't evaluate to the enabled plugin ids. Every box showed unchecked, even HTMLSubset, the default. Saving the page for any reason then stored an empty users.comments.plugins, which turned off HTMLSubset and every other comment plugin site-wide.

  • roller-6.1.x escapes HTML comments when HTMLSubset doesn't run, so they showed as escaped markup.
  • In 6.1.7, which escapes only text/plain comments, HTML comments were shown unfiltered once HTML comments were allowed.

Without the value attribute, the list checks the plugins in commentPlugins, which the action loads from users.comments.plugins. The bug dates from e83e5f8 (2018). The master fix, with a Playwright check that failed before it and passes after, is a separate PR.

The comment plugin checkbox list set value="name", which doesn't evaluate to the enabled plugin ids, so every box showed unchecked. Saving the page then stored an empty plugin list, which turned off HTMLSubset, the default comment plugin, and every other comment plugin site-wide. Without the value attribute, the list checks the plugins in commentPlugins, which the action loads from users.comments.plugins.
@mraible
mraible requested a review from snoopdave November 18, 2026 17:38

@snoopdave snoopdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraible
mraible merged commit a76d47b into roller-6.1.x Nov 18, 2026
7 checks passed
@mraible
mraible deleted the keep-comment-plugins-6.1.x branch November 18, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants