Repository navigation
Conversation
Banned words rules are regular expressions: rules that start with ( directly, and every other rule as \b(rule)\b. A weblog's own banned words and the site's list are compiled as written, so a rule like ((x+)+)+y held a comment post (checked against the commenter's name, e-mail, URL and text) or a referrer check for as long as it backtracked, which CodeQL flags as regex injection. Each value is now matched through a CharSequence that stops the match once 1 second has passed. The value then counts as a match, so a comment that sets off such a rule is caught as spam, and the rule is logged so it can be simplified. Ordinary checks take a few milliseconds; 40,000 characters against the bundled list take about 24 ms. (cherry picked from commit 805dbc6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Banned words rules are regular expressions: rules that start with
(directly, and every other rule as\b(rule)\b. A weblog's own banned words and the site's list are compiled as written, so a rule like((x+)+)+yheld a comment post or a referrer check for as long as it backtracked. CodeQL flags this as regex injection (alert 95). A comment post checks the commenter's name, e-mail, URL and text.CharSequencethat stops the match once 1 second has passed.The new BannedwordslistTest case uses
((x+)+)+yas a regex rule and as a word rule. It timed out before the fix on both lines and passes after.This is the master change cherry-picked; the 6.1.x unit suite passes (561 tests, 1 skipped).