Skip to content

K2GO-588 feat(privacy): one choice for usage data, crash reports and automatic connections - #815

Open
luisguzman-adfa wants to merge 4 commits into
mainfrom
feat/K2GO-588-one-privacy-choice
Open

luisguzman-adfa wants to merge 4 commits into
mainfrom
feat/K2GO-588-one-privacy-choice

Conversation

@luisguzman-adfa

Copy link
Copy Markdown
Collaborator

What changes

  • One stored choice (OnlineConsent) replaces the analytics and crash-report opt-ins. The earlier analytics answer carries over; every other user stays offline.
  • The automatic-fetch rule (NetworkCostAdmission.allowsAutomatic) also needs the choice on. App and dash-node update checks, the Kolibri Studio tree, the live rootfs size and the Kiwix directory read stop when the choice is off.
  • Settings > About: one switch. The onboarding asks the question in every flavor (F-Droid too), also when the wizard resumes at the setup choice.
  • Crash reports: events only, no Sentry sessions; turning the choice off closes Sentry.
  • In-app WebViews load only local hosts; an internet page shows a short offline note.
  • One neutral User-Agent (K2Go) for app HTTP calls; the two Mozilla/5.0 overrides are removed.
  • The unused legacy setup and about screens (a second copy of the consent UI) are removed.
  • UI changes:
    • Onboarding title: "Privacy & analytics" -> "Privacy and online content".
    • Onboarding button and About switch: "Share anonymous data" / "Share usage statistics" + "Send crash reports" -> "Share usage data and request online content" (F-Droid: "Send crash reports and request online content").
    • Onboarding body rewritten for the one choice; new WebView note "This page is on the internet. Pages inside the app work offline only."
    • All locales translated (machine translation, review welcome).

Why

  • K2GO-588: "Keep offline" said "sends nothing" but the app still connected on its own; crash reports were a second switch; F-Droid users had no choice.

Steps to QA

  • Baseline: main, choose "Keep offline": the OTA check (update.json) still runs at each launch on Wi-Fi.
  • Change: clear app data, run the wizard: the privacy question shows. Choose "Keep offline": relaunch, no update.json request and Sentry does not start. Turn the switch on in Settings > About: the next launch checks update.json and starts Sentry.

Verifications

  • Unit tests, lint (0 errors), standard and fdroid compile.
  • Device: OnePlus 7T, wizard question, Keep offline vs on (logcat). Evidence goes to K2GO-588 in Jira.
  • Deferred: PR 2 (grey actions with "Allow only this time", catalog refresh, feedback, box Privacy) and PR 3 (remove BitTorrent), same ticket.

Notes

  • No new permission or dependency.
  • The old consent strings stay in strings.xml (unused) to avoid conflicts in the 34 locale files.

…automatic connections

One stored choice replaces the analytics and crash-report opt-ins; the automatic-fetch rule and the
Kiwix directory read follow it. Asked in every flavor, one switch in Settings > About. Crash events
only (no Sentry sessions); off closes Sentry. Neutral User-Agent for app HTTP calls.
Only local hosts load; an internet page shows a short offline note instead of a blank screen.
…eens

They held a second copy of the consent UI and were no longer reachable.
… it resumes at setup

With permissions already granted the wizard opens at the setup choice and skipped the question.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant