Repository navigation
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
commit: |
cowboyd
marked this pull request as ready for review
November 15, 2026 22:33
cowboyd
force-pushed
the
dom-selectors
branch
from
November 15, 2026 22:36
a8d37cb to
04dde52
Compare
2 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The WPT relies heavily on query selectors functioning (along with an HTML parser for fixtures). This begins adding CSS selector support to our dom.
The first proof of concept is
Element.matches()support usingcss-selectand an adapter for the UI DOM. The adapter supplies element names, attributes, text, and tree traversal; selector compilation failures becomeSyntaxErrorDOMExceptions.Adds WPT coverage for unqualified tag names on namespaced elements, the default inactive state of
:active, invalid selector syntax, and child-indexed pseudo-classes on detached elements. Existing static HTML fixtures load through the document factory, preserving their assertions while removing the adaptations' incidental dependency oninnerHTML.Limtations:
:nth-*(n)selectors because of css-select #1945. Those four WPT cases are temporarily excluded in the UI configuration until the upstream issue is fixed.*|hcase is excluded because css-select rejects namespace-qualified tag selectors.Type of change
Checklist
AI-generated code disclosure