Repository navigation
Conversation
Upstream Rust's QNX 8.0 targets, x86_64-pc-qnx and aarch64-unknown-qnx, report target_os = "qnx". Every QNX cfg in rustix tests target_os = "nto", so on those targets the libc backend is compiled with no QNX arms and the build stops at src/backend/libc/io/errno.rs:253 (cannot find value EDOTDOT in module c), followed by about 150 more errors with all-apis. build.rs now sets an nto cfg for both target_os = "nto" and target_os = "qnx", the same grouping libc uses (both live in its nto module), and the QNX cfgs use it, like apple, bsd and solarish. AF_NS exists only in io-pkt, the QNX 7 network stack. io-sock (QNX 7.1 iosock and QNX 8) has no AF_NS, so AddressFamily::NS is now limited to the nto70 and nto71 environments; before this, all-apis also failed on x86_64-pc-nto-qnx710_iosock. Built with nightly -Zbuild-std, default features and all-apis: x86_64-pc-qnx, aarch64-unknown-qnx, x86_64-pc-nto-qnx710, x86_64-pc-nto-qnx710_iosock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustix does not build for upstream Rust's QNX 8.0 targets.
x86_64-pc-qnxandaarch64-unknown-qnx(see the nto-qnx platform page) reporttarget_os = "qnx", and every QNX cfg in rustix teststarget_os = "nto", so the libc backend compiles with no QNX arms:With
all-apisthere are about 150 errors. tempfile and everything else that reaches rustix stop there on these targets.Change
build.rssets anntocfg for bothtarget_os = "nto"andtarget_os = "qnx". That is the grouping libc uses (both are in itsntomodule), and the same pattern asapple,bsdandsolarish. The QNX cfgs use it (a mechanicaltarget_os = "nto"tontoreplacement, plusrustfmt), andcfg(nto)is added to thecheck-cfglist.AddressFamily::NS:AF_NSexists only in io-pkt, the QNX 7 network stack. io-sock (QNX 7.1 iosock and QNX 8) has noAF_NS, so it is now limited totarget_env = "nto70"/"nto71". Before this,all-apisalso failed onx86_64-pc-nto-qnx710_iosockat src/net/types.rs:700.Checked with
cargo +nightly build -Zbuild-std=std,panic_abort, default features and--features all-apis:x86_64-pc-qnx,aarch64-unknown-qnx,x86_64-pc-nto-qnx710,x86_64-pc-nto-qnx710_iosock. On main the first two fail as above and the iosock target fails atAF_NSwithall-apis.cargo fmt --checkis clean and stablecargo check --features all-apispasses forx86_64-unknown-linux-gnu. These are build checks; I have not run the test suite on a QNX 8 kernel.Found with
atlas claimsfrom qnx-crate-atlas, which I maintain: it builds every top-500 crate for the targets it claims, and rustix failed the upstream QNX build.