Repository navigation
Depend on @cap2ui5/cds-plugin ^0.6.0 and @abap2ui5/linter ^0.10.0 - #8
Merged
Merged
Conversation
0.6.0 hosts @abap2ui5/node-runtime 1.149.0 (abap2UI5 1.149.0). Neither sample needs a change for it: both close their popup with the frontend action already, neither view names one of the eight invisible custom controls 1.149.0 removed, and their remote calls answer well inside the minute 0.6.0 gives an async main( ) by default. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014YZFmCjdbLvb757NWCFVeA
The tests hold every view and popup the two samples display to the linter's property gate at UI5 1.71 (ui5Findings( ) in test/server.mjs); 0.10.0 finds nothing in them, as 0.9.0 did. Its new source rules - close-only-roundtrip, bind-path-flag, ui5-internal-access - read ABAP classes, which this repository does not have, and what they look for is not in the two modules either: the popups close through follow_up_action( cs_event.popup_close ), no _bind( ) passes path, and no event argument or expression binding reads a private UI5 field. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014YZFmCjdbLvb757NWCFVeA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two commits,
package.jsononly (the lockfile is git-ignored):@cap2ui5/cds-plugin^0.5.0→^0.6.0(published 2026-11-16; hosts@abap2ui5/node-runtime1.149.0)@abap2ui5/linter^0.9.0→^0.10.0No app code needed changing. Read against the linter's new rules by hand: both popups close through
follow_up_action( cs_event.popup_close ), no_bindpassespath, no event argument or expression binding reads a private UI5 field, and neither app uses a control or class 1.149.0 removed.Verified
npm run lintnpm testThe linter is used here through
checkXmlSourceintest/server.mjs(the property gate at UI5 1.71 on every displayed view and popup), which is clean on 0.10.0. Its ABAP-source rules do not apply: the two apps are JavaScript.Not verified
npm test).Generated by Claude Code