Repository navigation
refactor(shared,ui): move the sign-up form field rules into shared - #10868
austincalvelage wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: ac874b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
|
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
3b7347f to
f94ce4f
Compare
f94ce4f to
e0a37cc
Compare
e0a37cc to
ccf6d2a
Compare
ccf6d2a to
353f72b
Compare
determineActiveFields and its helpers move from ui's signUpFormHelpers to @clerk/shared/internal/clerk-js/signUpFormFields, so Mosaic uses the same rules. ui's signUpFormHelpers re-exports them and keeps FormState, its only ui-specific type.
353f72b to
53afeda
Compare
|
| Merge-base | This PR 256b4968 |
|---|---|
Also checked · 1 match
Proof on 256b4968 (from 53afeda5) · Did Proof get it right? Yes · No
View full Proof report · React 👎 or comment @codesmith dismiss this proof to dismiss
API Changes Report
Summary
@clerk/sharedCurrent version: 4.46.0 Subpath
|
…ngSignup It now takes the fields it reads instead of the legacy SignUpResource, so Mosaic can pass the SignUpFuture resource.


Description
The existing sign-up form and Mosaic need the same rules for deciding which fields to show and require. This moves those rules and their tests to
shared. The existing form keeps its imports through re-exports inui.minimizeFieldsForExistingSignupnow acceptsExistingSignUpInput, which describes the profile fields and verification statuses it reads. Mosaic can pass its sign-up data without constructing a fullSignUpResource.The blocked-request parser also moves to
sharedso both UIs can read the details of a blocked request from the same Clerk error.uire-exports the parser from its existing path.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change