Repository navigation
feat(ui): show a support reference on a failed verification check, and start over after an expired one - #10884
zourzouvillys wants to merge 1 commit into
Conversation
…d start over after an expired one
🦋 Changeset detectedLatest commit: ee82297 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
API Changes Report
Summary
@clerk/uiCurrent version: 1.43.0 Subpath
|
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|



Description
When a verification check during sign-in or sign-up didn't complete in time, the card showed "Verification didn't complete in time. Please try again." Two problems:
sia_… · protect_check_timed_out. It reuses the existing "Reference" label. Three new appearance elements style it:protectCheckReferenceBox,protectCheckReferenceLabelandprotectCheckReference.What this does not change
ClerkRuntimeErrorwhosecodeisprotect_check_timed_out. A custom flow already holdssignIn.id/signUp.id, which is the same reference, and callingcreate()again gets a new check.How to test
Get a sign-in into a verification check that has expired (
expiresAtin the past). The card shows the error, the reference, and "Try again". Clicking it returns to the sign-in start.Verification
pnpm exec vitest runonSignInProtectCheck,SignUpProtectCheckandProtectCheckModal: 3 files passed, 67 tests passed.@clerk/uisuite (pnpm exec vitest runinpackages/ui): 204 files passed; 2992 tests passed, 9 skipped, 12 todo.pnpm type-checkinpackages/ui: clean.eslint --quieton the changed files: clean.pnpm build: not run.Checklist
pnpm testruns as expected (the@clerk/uisuite; see Verification).pnpm buildruns as expected.Type of change