Repository navigation
Restore WCA login in production builds - #276
Merged
Merged
Conversation
GitHub Actions built the browser bundle without the public OAuth application ID. Pass the configured ID to Docker and fail before building if the repository variable is missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The production workflow built the browser bundle without the public WCA OAuth client ID. The login link therefore sent an empty
client_idto the WCA.Pass the repository variable to Docker and stop the build if it is missing. The configured value matches the client ID in the production API.
The deployment workflow, image release, and Compose checks passed locally.