Repository navigation
fix(cdk): connect the cron lambdas to RDS over verified TLS - #1349
Conversation
The RSS fetcher and vote-reconcile lambdas connected without TLS, which RDS has rejected since the Postgres 15 upgrade turned rds.force_ssl on, so both have failed on every run. They now use TLS and verify the server certificate against the RDS CA bundle that ships in the Lambda runtime. Verification needs a valid server certificate: the instance still served one issued under rds-ca-2019, which expired in August 2024. Move it to rds-ca-rsa2048-g1 (Postgres 15 rotates without a restart).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Uh oh! @vercel[bot], the image you shared is missing helpful alt text. Check #1349 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
|
No actionable comments were generated in the recent review. WalkthroughThe RDS instance now specifies a CA certificate. The RSS fetcher and vote reconciliation Lambdas receive the CA certificate environment setting and enable SSL in their PostgreSQL client configurations. ChangesRDS TLS Configuration
Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Merge Risk:
|
|
Uh oh! @coderabbitai[bot], the image you shared is missing helpful alt text. Check #1349 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
1 similar comment
|
Uh oh! @coderabbitai[bot], the image you shared is missing helpful alt text. Check #1349 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
RDS rejects a parameter group description containing non-ASCII characters, so the stack could not deploy.
|
Uh oh! @vercel[bot], the image you shared is missing helpful alt text. Check #1349 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
|
Uh oh! @coderabbitai[bot], the image you shared is missing helpful alt text. Check #1349 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
|
Uh oh! @vercel[bot], the image you shared is missing helpful alt text. Check #1349 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
|
Uh oh! @coderabbitai[bot], the image you shared is missing helpful alt text. Check #1349 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
1 similar comment
|
Uh oh! @coderabbitai[bot], the image you shared is missing helpful alt text. Check #1349 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
Pull Request details
The RSS fetcher and vote-reconcile lambdas have failed on every run since the database moved to Postgres 15, in both accounts. Postgres 15 on RDS turns
rds.force_sslon, and the lambdas connected without TLS:So no feed source has been ingested, and vote counts have not been reconciled, since then.
ssl: trueon thepgclient. Node 20+ Lambda runtimes no longer trust the Amazon RDS CAs by default, so the two lambdas load the CA bundle that ships in the runtime.rds-ca-2019, which expired in August 2024, so a verifying client fails withcertificate has expired. The stack now setsrds-ca-rsa2048-g1. Postgres 15.17 supports rotating the certificate without a restart.Evidence
no encryptionerror above on every scheduled run.certificate has expired, which is the expired instance certificate.All counts in sync;sourcesProcessed: 34, articlesAdded: 195, with one source answering 403;rds-ca-rsa2048-g1and the new parameter groupin-sync. It is the same instance (creation time unchanged), and the parameter group restart took about 17 seconds.Any Breaking changes
Door: two-way. No schema change. The certificate authority can be set back, and the lambdas only take effect on a CDK deploy.
Blast radius: contained.
rds.force_sslparameter group that is already indevelopbut has never been deployed. Attaching it restarts the instance once (about 17 seconds on Dev).sslmode=requireand do not verify the certificate, which includes the app, are unaffected by the certificate change.Associated Screenshots
None
[Optional] What gif best describes this PR or how it makes you feel
None