Repository navigation
ci(e2e): run on pull_request instead of pull_request_target - #1350
NiallJoeMaher wants to merge 1 commit into
Conversation
The workflow checked out the PR head under pull_request_target, which runs fork code with the base repo's token and secrets. actions/checkout now refuses that, so every fork PR failed at checkout. Switch to pull_request (default merge-commit checkout, no secrets for forks) and fall back to a placeholder NEXTAUTH_SECRET, since e2e seeds its sessions directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
|
|
Uh oh! @coderabbitai[bot], the image you shared is missing helpful alt text. Check #1350 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
|
Uh oh! @vercel[bot], the image you shared is missing helpful alt text. Check #1350 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
What
Switch the E2E workflow trigger from
pull_request_targettopull_request, drop the explicitref: head.shacheckouts, and fall back to a placeholderNEXTAUTH_SECRETwhen secrets aren't available.Why
Every fork PR currently fails
initial-checksat checkout (e.g. #1347):Checking out the fork's head under
pull_request_targetruns untrusted code (npm ci, Playwright) with the base repo's token and secrets — a "pwn request".actions/checkoutnow blocks it by default. Rather than opting back in withallow-unsafe-pr-checkout, this moves topull_request, which checks out the merge commit and gives fork runs no secrets.E2E seeds its sessions directly in the database, so it doesn't need the real
NEXTAUTH_SECRET; a placeholder keeps NextAuth happy on fork runs. Same-repo PRs and pushes todevelopstill use the real secrets.Notes
greetings.ymlalso usespull_request_targetbut never checks out PR code, so it's left as-is.🤖 Generated with Claude Code