Skip to content

ci(e2e): run on pull_request instead of pull_request_target - #1350

Open
NiallJoeMaher wants to merge 1 commit into
developfrom
ci/e2e-pull-request-trigger
Open

NiallJoeMaher wants to merge 1 commit into
developfrom
ci/e2e-pull-request-trigger

Conversation

@NiallJoeMaher

Copy link
Copy Markdown
Contributor

What

Switch the E2E workflow trigger from pull_request_target to pull_request, drop the explicit ref: head.sha checkouts, and fall back to a placeholder NEXTAUTH_SECRET when secrets aren't available.

Why

Every fork PR currently fails initial-checks at checkout (e.g. #1347):

Refusing to check out fork pull request code from a 'pull_request_target' workflow.

Checking out the fork's head under pull_request_target runs untrusted code (npm ci, Playwright) with the base repo's token and secrets — a "pwn request". actions/checkout now blocks it by default. Rather than opting back in with allow-unsafe-pr-checkout, this moves to pull_request, which checks out the merge commit and gives fork runs no secrets.

E2E seeds its sessions directly in the database, so it doesn't need the real NEXTAUTH_SECRET; a placeholder keeps NextAuth happy on fork runs. Same-repo PRs and pushes to develop still use the real secrets.

Notes

🤖 Generated with Claude Code

The workflow checked out the PR head under pull_request_target, which runs
fork code with the base repo's token and secrets. actions/checkout now
refuses that, so every fork PR failed at checkout. Switch to pull_request
(default merge-commit checkout, no secrets for forks) and fall back to a
placeholder NEXTAUTH_SECRET, since e2e seeds its sessions directly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@NiallJoeMaher
NiallJoeMaher requested a review from a team as a code owner November 18, 2026 14:15
@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
codu Ready Ready Preview Nov 18, 2026 2:17pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1

  • .github/workflows/e2e-tests.yml is excluded by !**/*.yml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3e86c513-ba7c-4a46-8ce3-f7699a59ce97

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown

Uh oh! @coderabbitai[bot], the image you shared is missing helpful alt text. Check #1350 (comment).

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@github-actions

Copy link
Copy Markdown

Uh oh! @vercel[bot], the image you shared is missing helpful alt text. Check #1350 (comment).

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

This branch was successfully deployed

2 active deployments
production — 9e562a77 Deployed Nov 18, 2026 by NiallJoeMaher via e2e #662
Preview — 9e562a77 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant