Repository navigation
fix(environments): skip env:update when flags match the current settings - #296
Open
SakshiKoli-CS wants to merge 1 commit into
Open
SakshiKoli-CS wants to merge 1 commit into
SakshiKoli-CS wants to merge 1 commit into
Conversation
…ings launch:env:update sent a PUT whenever any flag was passed, even when every value equalled what the environment already had: it reported success and moved updatedAt. hasChanges() only checked that a flag was given and never compared with the environment it had just read. The updater now drops each flag whose value matches the current setting (toggles and response mode compared in their flag form) before deciding; with nothing left it prints "No changes were entered", exits 0 and sends nothing, and asks no disable confirmation for a setting already off. --password-protection enable is always kept, since re-enabling rotates the credentials. The interactive response-mode prompt defaults to the current mode when the API reports it. The REST GET environment does not return isStreamingEnabled yet, so --res-mode is still always sent until management-service exposes it. .talismanrc checksums refreshed for the three edited files. #claude_code# 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
✅ BUILD PASSED - All security checks passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: CL-8833
What
launch:env:updatesent aPUTwhenever any flag was passed, even when every value equalled the environment's current setting. It reported "✔ Environment updated successfully." and movedupdatedAt.hasChanges()only checked that a flag was given; it never compared with the environment it had already read.enable/disable,streaming/buffered).--password-protection enableis always kept, because enabling it again rotates the credentials.toggleOf/responseModeOfnow live inenvironment.inputs.ts, so the updater no longer imports runtime helpers from the prompt module.Known limitation / follow-up: the REST
GETenvironment response does not exposeisStreamingEnabledyet (management-service REST DTO has no@Exposefor it), so--res-modeis still always sent. The CLI compares it automatically once the API returns it.Overlap: #295 (CL-8827) drops
--descriptionfrom the same files. Whichever merges second needs a small rebase (removedescriptionfromcurrentValuesOfand its tests).Tests
--frameworkdropped while--server-cmdis checked against the current framework; response-mode prompt default.PUT.npm test: 3883/3883 passed;tscand eslint clean.#claude_code#
🤖 Generated with Claude Code