Repository navigation
Conversation
Update Prometheus to v0.316.0, with Thanos, promql-engine and parquet-common pinned to forks until their upstream PRs merge: thanos-io/thanos#9153, thanos-io/promql-engine#756 and the parquet-common bump. Signed-off-by: Alan Protasio <alanprot@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updates
github.com/prometheus/prometheusfrom v0.309.1 to v0.316.0. Among other things this brings in early compaction of stale head series (prometheus/prometheus#16929,DB.CompactStaleHead), which we want to evaluate for ingesters separately.Draft: Thanos, promql-engine and parquet-common don't build against v0.316.0 yet, so
go.modtemporarily pins them to forks:github.com/thanos-io/promql-enginegithub.com/thanos-io/thanosgithub.com/prometheus-community/parquet-commonchunkenc.Appenderstart-timestamp arguments (PR to follow)These
replacedirectives will be removed once those merge.Code changes
parser.ParseExpr/ParseMetricSelectorare gone.pkg/parserkeeps the experimental-functions setting itself and addsNewEngineParser(), which also includes the Thanosxrate/xincrease/xdeltafunctions (promql-engine no longer registers them globally). Used by the engines, the query API, the query analyzer, distributed query planning and rule validation.engine.Optsno longer embedspromql.EngineOpts; options are mapped explicitly.rules.ManagerOptionstakes anAppendableV2;PusherAppendablenow implements it (RejectOutOfOrdermaps to the existingDiscardOutOfOrder). The local rule store uses a newlocal.FileLoader, because a zero-valuerules.FileLoader{}now panics when parsing expressions. Discovery metrics use*discovery.SDMetrics.storage.AppenderV2;collectingAppenderimplements it, and now also records float histograms.AtST()for the batch and compatible-chunk iterators (no start timestamps, returns 0).tsdb/errorswas removed →pkg/util/multierror;relabel.Process→ProcessBuilder;NewActiveQueryTrackernow returns an error (we keep failing at startup, as before);v1.NewAPI,NewPrometheusQueryOpts,rulefmt.Parseand chunk appender signatures; client_golangQuery*return an extra value.User-visible changes
;(from the upstream translator).prometheus_notifications_dropped_totalin the ruler now has analertmanagerlabel.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flagsTesting
go build,go test -run '^$'(including./integration/...with all integration tags) andgolangci-lint run(0 issues) with-tags "netgo slicelabels"and-mod=vendor.go test ./pkg/... ./cmd/... ./tools/...: all packages pass.pkg/ring/kv/memberlistTestPagefailed once on a port clash with a parallel package (bind: address already in use) and passes on its own.