Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .bot/prompts/engineer/system.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,11 @@ up whatever it needs.
== HOW TO WORK (bug-fix flow) ==

0. **Pick the BACKEND the bug is on — reproduce on that one.** The connector has
three backends and a bug on one won't reproduce on another. Choose from the
two backends and a bug on one won't reproduce on another. Choose from the
issue:
- **kernel** (`use_kernel=True`) — only if the issue is specifically about the
Rust kernel / `use_kernel`. Repro in `tests/e2e/test_kernel_backend.py` and run
it alone (it needs the real wheel; see the `-m "not realkernel"` note above).
- **SEA** (`use_sea=True`) — if the issue implicates SEA, or the area is
backend-parametrized (add the `{"use_sea": True}` param case).
- **Thrift** (the default, no kwarg) — everything else; this is the common case.
See CONTRIBUTING.md → "Backends and test tiers" for the full matrix (selection
kwarg + where each backend's tests live).
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Release History

# Unreleased
- Remove the deprecated pure-Python SEA backend. Passing `use_sea=True` now raises `ValueError`; use `use_kernel=True` to connect through the Rust kernel instead. The SEA-only `use_hybrid_disposition` and `max_connections` options are removed and ignored if passed.
- Honor `max_download_threads` on kernel connections, with a default download window of 16 and explicit chunk-setting overrides. Invalid values raise `ValueError` when connecting with `use_kernel=True`.
- Fix the kernel backend ignoring `use_cloud_fetch=False`, so complete results can be fetched without cloud-storage downloads.
- Fix inline parameters (`use_inline_params=True`) so a sequence directly after `IN` renders as a list again: `x IN %(ids)s` renders as `x IN (1,2,3)` instead of `x IN ARRAY(1,2,3)`, which Spark rejects. Inside the list, tuples render as rows for a multi-column `IN`, and a `set` or `frozenset` is accepted again. Sequences anywhere else still render as `ARRAY(...)` ([#629](https://github.com/databricks/databricks-sql-python/issues/629))
Expand Down
14 changes: 3 additions & 11 deletions CONNECTION_PARAMETERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@ but ignored (or rejected) on the other is called out in the **Note** column.
> does **not** splat `**kwargs`. Options implemented in the shared Python driver
> layer can still apply to both backends; unforwarded backend-specific options
> are ignored or rejected on the kernel path.
>
> A separate pure-Python **SEA** backend (`use_sea=True`) also exists but is
> being deprecated. Its selector and SEA-only hybrid-disposition option are
> listed for completeness, but this reference does not provide a third SEA
> support column.

## Legend

Expand Down Expand Up @@ -58,12 +53,9 @@ to change without notice.

## Backend selection

| Option | Type | Thrift | Kernel | Default Value | Note |
| ------------------------ | ------ | :----: | :----: | ------------- | -------------------------------------------------------------------------------------------------- |
| `use_kernel` | `bool` | — | — | `False` | Routing selector: `False` selects Thrift; `True` selects Kernel. Mutually exclusive with `use_sea`. |
| `use_sea` | `bool` | — | — | `False` | Select the deprecated pure-Python SEA backend. Mutually exclusive with `use_kernel`. |
| `use_hybrid_disposition` | `bool` | ❌ | ❌ | `False` | SEA-only result-disposition option; ignored by Thrift and Kernel. |
| `max_connections` | `int` | ❌ | ❌ | `10` | Internal SEA-only HTTP-pool limit; ignored by Thrift and Kernel. |
| Option | Type | Thrift | Kernel | Default Value | Note |
| ------------ | ------ | :----: | :----: | ------------- | ---------------------------------------------------------------- |
| `use_kernel` | `bool` | — | — | `False` | Routing selector: `False` selects Thrift; `True` selects Kernel. |

---

Expand Down
9 changes: 3 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,6 @@ There are several e2e test suites available:
- `PySQLCoreTestSuite`
- `PySQLLargeQueriesSuite`
- `PySQLStagingIngestionTestSuite`
- `PySQLRetryTestSuite.HTTP503Suite` **[not documented]**
- `PySQLRetryTestSuite.HTTP429Suite` **[not documented]**
- `PySQLUnityCatalogTestSuite` **[not documented]**

To execute the core test suite:
Expand All @@ -146,14 +144,13 @@ The suites marked `[not documented]` require additional configuration which will

#### Backends and test tiers

The connector has **three execution backends**, selected per connection. When you
The connector has **two execution backends**, selected per connection. When you
reproduce or fix a bug, use the backend the bug is actually on — a Thrift bug won't
reproduce on a SEA or kernel connection, and vice versa:
reproduce on a kernel connection, and vice versa:

| Backend | Select via (connect kwarg / `extra_params`) | Where its tests live |
| --- | --- | --- |
| **Thrift** (default) | *(nothing — the default path)* | the general `tests/e2e` suite (the `{}` parametrize case) and mocked `tests/unit` |
| **SEA** (Statement Execution API) *(deprecated — use Kernel for SEA-native connections)* | `use_sea=True` | the general `tests/e2e` suite (the `{"use_sea": True}` parametrize case, e.g. `tests/e2e/test_driver.py`) and mocked `tests/unit` |
| **Thrift** (default) | *(nothing — the default path)* | the general `tests/e2e` suite and mocked `tests/unit` |
| **Kernel** (Rust, optional) | `use_kernel=True` | the dedicated `tests/e2e/test_kernel_backend.py` / `test_kernel_tls.py`, plus the offline routing test `tests/unit/test_session.py -m realkernel` |

Notes that matter when running the suite:
Expand Down
126 changes: 0 additions & 126 deletions examples/experimental/sea_connector_test.py

This file was deleted.

Empty file.
Loading
Loading