Skip to content

chore: rename the monolith to the assembled tree - #28

Merged
rvandenassum merged 3 commits into
mainfrom
feature/17-11-2026-assembled-tree-rename
Nov 17, 2026
Merged

rvandenassum merged 3 commits into
mainfrom
feature/17-11-2026-assembled-tree-rename

Conversation

@rfernandesdossantos

Copy link
Copy Markdown
Contributor

Description

Renames "monolith" in one clean cut: the package that needs nothing in the target org is the standalone package, the generated folder it is built from is the Assembled tree, now assembled/. No behaviour change.

Summary

 sfdx-project.json / .gitignore
-monolith/
+assembled/
 build/scripts/
-assemble-monolith.cjs        MONOLITH_PATH, output monolith-path
+assemble.cjs                 ASSEMBLED_PATH, output assembled-path
 assemble-guards.cjs
-  checkMonolithUntracked     finding monolith-untracked
+  checkAssembledUntracked    finding assembled-untracked
 release-package-set.cjs
-  PACKAGE_KIND.MONOLITH = 'monolith', monolithFirst
+  PACKAGE_KIND.STANDALONE = 'standalone', standaloneFirst
 .github/actions/
-assemble-monolith/           "Assemble monolith"
+assemble/                    "Assemble the tree" (workflow steps too)
 release-pr.yml, validate-project.yml paths
-  build/scripts/assemble-*.cjs
+  build/scripts/assemble*.cjs   still covers assemble.cjs

CONTRIBUTING uses the new folder, script and variable names. Unchanged: Dev Hub package names, the required check assemble-guards, release notes output.

Evidence

  • Before: git grep -i monolith hits the action, 5 workflows, 8 build scripts, sfdx-project.json, .gitignore and CONTRIBUTING.
    After: no hit.
  • node build/scripts/assemble.cjs builds assembled/, every guard passes, git ignores the folder.
  • validate-project and assemble-guards run on this pull request with the renamed action.

Merge Danger

Door: two-way

A revert restores every name. The content tag changes, because assemble.cjs is a content input of release-content-tag.cjs: a beta build recorded before the merge goes stale, so it is rebuilt (one of six daily creates) and publish refuses until then. Merge before a beta is built for the open release PR, or after that release is published; never between a beta build and its publish.

Blast Radius: contributors

After pulling, each clone and worktree deletes its old monolith/ folder by hand: it is no longer ignored. Open branches that touch the renamed files rebase onto this.

Checklist

  • My PR title follows the Conventional Commits format
  • My code follows the project's coding standards
  • I have tested my changes locally
  • I have updated documentation if needed

@github-actions github-actions Bot added the ci Changes to workflows, build scripts and the release-please config label Nov 17, 2026
@github-actions

Copy link
Copy Markdown

✅ PR Template Validation Passed

  • Type: chore (detected from title)
  • Description: Valid (220 characters)
  • Checklist: 4 item(s) checked

@github-actions github-actions Bot added chore Maintenance tasks community External contributor PR labels Nov 17, 2026
rvandenassum
rvandenassum previously approved these changes Nov 17, 2026

@rvandenassum rvandenassum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfernandesdossantos big thanks for this, really appreciating this and do think relevant improvement. Like the new terminology of standalone and assembled. Thanks!

@rfernandesdossantos rfernandesdossantos self-assigned this Nov 17, 2026
@rfernandesdossantos rfernandesdossantos removed the community External contributor PR label Nov 17, 2026
@rfernandesdossantos
rfernandesdossantos force-pushed the feature/17-11-2026-align-pr-template-contributing branch from b59526a to ec42709 Compare November 17, 2026 15:36
Base automatically changed from feature/17-11-2026-align-pr-template-contributing to main November 17, 2026 19:04
@rvandenassum
rvandenassum dismissed their stale review November 17, 2026 19:04

The base branch was changed.

rvandenassum
rvandenassum previously approved these changes Nov 17, 2026
Signed-off-by: Reinier van den Assum <rvandenassum@deloitte.nl>
@github-actions github-actions Bot added the documentation Changes to Markdown documentation label Nov 17, 2026
@rvandenassum
rvandenassum merged commit 69c85d9 into main Nov 17, 2026
5 checks passed
@rvandenassum
rvandenassum deleted the feature/17-11-2026-assembled-tree-rename branch November 17, 2026 20:48
@rfernandesdossantos rfernandesdossantos mentioned this pull request Nov 17, 2026
4 tasks done

This branch was successfully deployed

1 active deployment
buildcheck — 415587ca Deployed Nov 17, 2026 by rvandenassum via validate-deployment #83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance tasks ci Changes to workflows, build scripts and the release-please config documentation Changes to Markdown documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants