Skip to content

Catch first-entry motion flashes and strengthen Figma audit evidence - #130

Merged
owjs3901 merged 3 commits into
mainfrom
devfive/3099154426bffbeef8b62999b80bb038/portfolio-retro-audit
Nov 20, 2026
Merged

owjs3901 merged 3 commits into
mainfrom
devfive/3099154426bffbeef8b62999b80bb038/portfolio-retro-audit

Conversation

@devfive-relay-c70423

@devfive-relay-c70423 devfive-relay-c70423 Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Why

A Figma-backed portfolio follow-up surfaced regressions that a successful export and a settled screenshot did not catch. A heading appeared at rest before fading in from below. A sticky header kept a divider over the hero. During triage, a multi-frame PNG request failed and a successful compare call still returned an inconclusive verification verdict.

Changes

  • Sample visible frames from the moment a fast scroll enters the target. Fail when a settled item disappears or moves back into its entrance, even if its final state is correct. Retain the before and after measurements in audit evidence.
  • Require fresh Figma-backed browser evidence after follow-up UI edits. Cover each affected state at the drawn widths, record user-approved differences, and verify transitions, detail actions and forms, delayed image swaps, and font stability through actual browser behavior.
  • Add changed-pixel bounds, mean maximum channel delta and capture recovery guidance to visual comparisons. Keep strict thresholds and the final verdict independent of the diagnostic metrics.
  • Document the single-frame reference PNG contract in the tool schema. Clarify direct Figma usage in the connection summary. In retro output, distinguish tool errors by code from an inconclusive visual result without retaining response bodies.

Verification

  • Rust unit, visual comparison, and Bridge export suites passed.
  • Chromium regression reproduces the visible-resting-frame flash at mobile and desktop widths. The valid one-shot reveal and the scroll-linked reveal controls also passed.
  • Checked Rust formatting and the staged diff. Included a patch changepack.

Scope is the devup-mcp runtime audit, bundled skills and tool diagnostics. The portfolio application is outside this PR.


Submitted via Devfive hub. Employee: ; device: 3099154426bffbeef8b62999b80bb038

Follow-up coverage

  • Hero and design comparison: signed brightness delta with an independent limit. Required visual evidence is keyed to the exact route, screen, width and source node, so an initial-state capture cannot satisfy a scrolled-state obligation.
  • Header and links: verify logo visibility, the same-route home action, divider and background in both states, bidirectional interpolation, reduced motion, and no underline in default, hover or pressed states.
  • Detail and inquiry: verify the approved description, inquiry entry point, a real choice change, pressed styling, invalid-submission animation, and the resulting draft contents.
  • Image and font loading: hold the next image response and decode separately while measuring painted frames, using either a next button or a swipe. Hold first-viewport fonts and measure paint-time positions and layout shifts.
  • Completion and MCP: require explicitly registered route/screen/width regression contracts and Figma state evidence. Expose the per-frame PNG constraint in the export schema and retain execution errors separately from comparison verdicts.

Validation: 950 targeted Rust tests passed, Clippy passed, and Chromium passed the regression fixtures and emitted-runner integration. All four new browser contracts also passed against the portfolio at 360px and 1440px.

@owjs3901
owjs3901 marked this pull request as ready for review November 20, 2026 09:07
@owjs3901
owjs3901 merged commit 7dd33a8 into main Nov 20, 2026
9 checks passed
@owjs3901
owjs3901 deleted the devfive/3099154426bffbeef8b62999b80bb038/portfolio-retro-audit branch November 20, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant