Skip to content

Guard optional iptables installation on minimal RHEL images - #1777

Open
Kaniska (v-Kaniska244) wants to merge 7 commits into
mainfrom
copilot/fix-common-utils-broke-ubi10-minimal
Open

Kaniska (v-Kaniska244) wants to merge 7 commits into
mainfrom
copilot/fix-common-utils-broke-ubi10-minimal

Conversation

@v-Kaniska244

@v-Kaniska244 Kaniska (v-Kaniska244) commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fix common-utils installation on UBI 10 minimal images. Fixes #1776

Changes

  • Skip iptables on RHEL/UBI 10 images where it is unavailable.
  • Continue installing iptables for Fedora, AlmaLinux, Rocky Linux, and other supported RPM distributions.
  • Preserve a single shared RPM installation transaction.
  • Keep bubblewrap and slirp4netns availability checks non-mutating.
  • Update the feature version to 2.7.2.
  • Document the EL10 iptables exception.

Validation

  • Bash syntax and ShellCheck passed.
  • JSON and diff validation passed.
  • Secret scanning passed.
  • CodeQL review completed.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@v-Kaniska244 Kaniska (v-Kaniska244) changed the title [WIP] Fix common-utils 2.7.1 breaking ubi10-minimal due to iptables Guard optional iptables installation on minimal RHEL images Nov 16, 2026
@v-Kaniska244
Kaniska (v-Kaniska244) requested a balanced review from Copilot November 16, 2026 08:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change making iptables optional on RPM-based distributions has no active review issues.

No open issues 🎉

What changed in this PR

Fixes common-utils installation on UBI 10 minimal, where iptables is unavailable, addressing issue #1776.

Changes:

  • Makes iptables optional on RPM-based distributions, alongside bubblewrap and slirp4netns.
  • Adds a UBI 10 minimal regression scenario that does not require iptables.
  • Bumps common-utils to 2.7.2 and documents the optional-package behavior.
File Description
test/​common-utils/​ubi-10-minimal.sh Checks the user, distribution, and core utilities without requiring iptables.
test/​common-utils/​scenarios.json Adds the UBI 10 minimal test scenario.
src/​common-utils/​NOTES.md Documents conditional installation of iptables on RPM distributions.
src/​common-utils/​main.sh Moves iptables from mandatory packages into the availability-checked optional list.
src/​common-utils/​devcontainer-feature.json Updates the feature version to 2.7.2.

Review effort: Balanced

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

common-utils 2.7.1 broke ubi10-minimal (rhel)

3 participants