Repository navigation
Guard optional iptables installation on minimal RHEL images - #1777
Open
Kaniska (v-Kaniska244) wants to merge 7 commits into
Open
Kaniska (v-Kaniska244) wants to merge 7 commits into
Kaniska (v-Kaniska244) wants to merge 7 commits into
Conversation
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change making iptables optional on RPM-based distributions has no active review issues.
No open issues 🎉
What changed in this PR
Fixes common-utils installation on UBI 10 minimal, where iptables is unavailable, addressing issue #1776.
Changes:
- Makes
iptablesoptional on RPM-based distributions, alongsidebubblewrapandslirp4netns. - Adds a UBI 10 minimal regression scenario that does not require
iptables. - Bumps common-utils to
2.7.2and documents the optional-package behavior.
| File | Description |
|---|---|
test/common-utils/ubi-10-minimal.sh |
Checks the user, distribution, and core utilities without requiring iptables. |
test/common-utils/scenarios.json |
Adds the UBI 10 minimal test scenario. |
src/common-utils/NOTES.md |
Documents conditional installation of iptables on RPM distributions. |
src/common-utils/main.sh |
Moves iptables from mandatory packages into the availability-checked optional list. |
src/common-utils/devcontainer-feature.json |
Updates the feature version to 2.7.2. |
Review effort: Balanced
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
common-utilsinstallation on UBI 10 minimal images. Fixes #1776Changes
iptableson RHEL/UBI 10 images where it is unavailable.iptablesfor Fedora, AlmaLinux, Rocky Linux, and other supported RPM distributions.bubblewrapandslirp4netnsavailability checks non-mutating.2.7.2.iptablesexception.Validation