Repository navigation
Conversation
Keep the shared HTTP handle and RPC group when WebSocket is disabled. Return instance connection metadata while retaining transport JSON encoding hints. Cover SSE-only startup and disposal, returned-descriptor RPC over both transports, nested and renamed routes, and transport-disabled controls.
|
@SaKaNa-Y is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
|
👁️🗨️ Review this pull request with grouped, summarized diffs at: raw result💭 analyzed by {
"headSha": "0a4222d847d787a629f3fda15c5599a094d356fa",
"result": {
"overallSummary": "Fixes `createDevServer()` so it always returns a usable, closable handle and so `handle.connectionMeta()` matches HTTP discovery (`__connection.json`): strict JSON RPC method names are included and kept live, static config values are serialized consistently, and relative WebSocket/SSE/MCP paths resolve correctly at nested and mount-root bases. Includes a large new regression test suite and a docs update describing the clarified contract.",
"groups": [
{
"key": "core-fix",
"label": "Dev server handle fix",
"summary": "Makes `createDevServer()` always return a closable handle (even with WebSocket disabled), aligns `handle.connectionMeta()` snapshots with HTTP discovery (including strict JSON method names read live from the RPC registry), and fixes relative path resolution for mount-root WebSocket/SSE/MCP endpoints.",
"category": "api",
"filePaths": [
"packages/devframe/src/adapters/dev.ts",
"packages/devframe/src/adapters/initiate.ts",
"packages/devframe/src/node/instance-shell.ts"
],
"critical": true,
"lineNotes": [
{
"path": "packages/devframe/src/node/instance-shell.ts",
"side": "additions",
"line": 822,
"text": "Shared HTTP servers now keep a handle/RPC group even when WS is disabled, fixing the previous throw-before-return bug for WebSocket-disabled configurations.",
"critical": true
},
{
"path": "packages/devframe/src/adapters/dev.ts",
"side": "additions",
"line": 237,
"text": "Deep-clones the devframe's connectionMeta via a JSON round-trip so static config values (e.g. `URL` instances) match HTTP discovery's JSON form, and mutating one snapshot can't affect later ones.",
"critical": true
}
]
},
{
"key": "tests",
"label": "Transport & discovery tests",
"summary": "New and updated regression tests covering SSE-only/HTTP-only handle lifecycle and port reuse, strict JSON method discovery (including methods registered after startup), nested mount-root path resolution, and parity between `handle.connectionMeta()` and `__connection.json`.",
"category": "tests",
"filePaths": [
"packages/devframe/src/adapters/__tests__/dev-transports.test.ts",
"packages/devframe/src/adapters/__tests__/dev.test.ts",
"packages/devframe/src/adapters/__tests__/initiate.test.ts",
"packages/hub/src/node/__tests__/initiate.test.ts",
"examples/custom-hub-next/tests/next-devframe-hub.test.ts"
],
"fileNotes": [
{
"path": "packages/devframe/src/adapters/__tests__/dev-transports.test.ts",
"text": "New test file exercising real WebSocket/SSE/HTTP calls against both discovery descriptors, mount-root path resolution, snapshot immutability, and handle lifecycle/port release."
}
]
},
{
"key": "docs",
"label": "Dev server docs update",
"summary": "Documents the full `StartedServer` shape, the fresh-snapshot behavior of `connectionMeta()`, and the relative-path resolution rules for discovery vs. the handle.",
"category": "docs",
"filePaths": [
"docs/content/2.adapters/3.dev.md"
]
}
],
"schemaVersion": 1,
"source": "llm",
"generatedAt": "2026-11-16T04:59:22.051Z",
"model": "vercel-ai-gateway/anthropic/claude-sonnet-5",
"locale": "en"
}
} |
Read method flags from the current RPC registry when a client requests the instance descriptor. This gives SSE-only handles and HTTP discovery the same encoding hints as WebSocket handles, including methods registered after startup.
SaKaNa-Y
force-pushed
the
fix/dev-server-sse-handle
branch
from
November 7, 2026 07:53
85e31b1 to
70282fa
Compare
Return a fresh connection descriptor for each handle call so a viewer can edit its copy without changing HTTP discovery. Resolve local RPC paths from the mount so viewers can connect from the server origin.
Serialize connection metadata using the discovery JSON format so static configuration can supply values with toJSON methods. Resolve same-origin MCP paths against the mount base for callers that receive the handle. Exercise both discovery paths with a real MCP initialize request and compare the published representation of a URL in static configuration.
Advertise the mount root as ./ so a discovery document under a nested path resolves WebSocket, SSE and MCP to the bound endpoint. Cover both discovery paths with real connections.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With WebSocket disabled,
createDevServer()opens an HTTP listener and then throws before returning the handle needed to close it. With WebSocket and SSE enabled, the handle advertises only WebSocket. HTTP discovery also omits the names of strict JSON methods, so an RPC client can send aMapto a handler that expects JSON.Return a closable handle for each transport configuration. Both discovery paths read the strict JSON method names from the current RPC registry, including methods registered after startup. Each call to
handle.connectionMeta()returns a fresh JSON snapshot, so static configuration values such asURLhave the same representation as in HTTP discovery.For a devframe mounted at
/nested/tool/, callers can reach the same MCP route from either descriptor. Same-origin WebSocket and SSE paths follow the same rule. If the endpoint is the mount root, HTTP discovery advertises./and the handle advertises/nested/tool/.handle.connectionMeta()/nested/tool/tools/mcphandle.origin__connection.jsontools/mcpEvidence
Mapbefore the handler runs. An unflagged method round-trips the sameMap.URLin its static configuration threwDataCloneError. The regression tests now initialize MCP through both descriptors and read the same URL string from both. Mutating a handle snapshot leaves subsequent snapshots and HTTP discovery intact./. The regression tests now make WebSocket and SSE calls and initialize MCP through both descriptors at the nested mount root.Local lint, documentation lint, Knip, typecheck and build passed. The full Vitest run passed 1,869 tests with 14 skipped on Node 26.8.1.
Merge Danger
Door: Two-way. The patch can be reverted without a data migration.
Blast Radius: Live connection discovery. RPC clients using a strict JSON method now reject unsupported values before dispatch. An incorrect path or method list can prevent a connection or select the wrong encoding.