Repository navigation
Conversation
|
@tonoizer is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
|
👁️🗨️ Review this pull request with grouped, summarized diffs at: raw result💭 analyzed by {
"headSha": "15f8d27414c1c9c0a557f105d67fa9a749633137",
"result": {
"overallSummary": "Fixes two accessibility/input bugs in the floating dock: a decorative brand mark that intercepted pointer events despite fading out, and minimized controls that stayed reachable by assistive tech, tab order, and (via the inactivity timeout) keyboard focus. Adds a dedicated Playwright fixture/spec exercising the real embedded dock to lock in the fix across layouts and auth states.",
"groups": [
{
"key": "dock-fix",
"label": "Dock focus/pointer fix",
"summary": "Makes the decorative brand mark ignore pointer input and hide it from assistive tech, marks minimized dock controls `inert`/`aria-hidden`, and keeps the dock expanded while a control retains keyboard focus so inactivity can't steal focus.",
"category": "ui",
"filePaths": [
"packages/hub-ui/src/client/components/dock/Dock.vue"
],
"critical": true,
"lineNotes": [
{
"path": "packages/hub-ui/src/client/components/dock/Dock.vue",
"side": "additions",
"line": 51,
"text": "New `isFocused` tracks focus-within the dock so minimization is suppressed while a control inside it has keyboard focus."
}
]
},
{
"key": "e2e-tests",
"label": "Floating dock e2e tests",
"summary": "Adds a Playwright fixture and browser regression tests covering center-click hit testing, shadow-root hit stacking, hidden-control accessibility/tab order, focus retention across inactivity, hover restoration, and dragging; knip.jsonc is updated to recognize the new fixture entry point loaded only via its HTML script tag.",
"category": "tests",
"filePaths": [
"tests/e2e/floating-dock.spec.ts",
"tests/e2e/_support/floating-dock/index.html",
"tests/e2e/_support/floating-dock/main.ts",
"knip.jsonc"
],
"fileNotes": [
{
"path": "tests/e2e/floating-dock.spec.ts",
"text": "Uses the real embedded custom element (via vite.embedded.config.ts) with a mocked transport context, exercising both unauthorized and trusted dock variants in horizontal and vertical layouts."
}
]
}
],
"schemaVersion": 1,
"source": "llm",
"generatedAt": "2026-11-16T06:32:33.780Z",
"model": "vercel-ai-gateway/anthropic/claude-sonnet-5",
"locale": "en"
}
} |
SaKaNa-Y
approved these changes
Nov 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The embedded floating dock fades its centered brand mark with opacity, which leaves the decoration eligible for pointer hit testing. Its minimized control wrappers also remain exposed to accessibility queries and keyboard focus after pointer events are disabled.
Testing
pnpm lintpnpm knippnpm test --run: 1,847 passed, 26 skipped; no type errorspnpm typecheck: 43 tasks passedpnpm build: 29 tasks passedpnpm exec playwright test --workers=4: all 31 Chromium tests passedValidation ran on Windows with Node 24.19.0 and the repository's pnpm 12.18.0. The unit suite used a temporary directory outside the user-home tree so package-manager detection in the existing onboarding tests did not inherit a home-level Yarn configuration.
Risks
Runtime browser coverage is Chromium-only. The focused fixture exercises the shared embedded dock directly; it does not add separate React and Vue application fixtures. Existing opacity transitions, hover reveal, and dragging remain covered.