Skip to content

fix(hub-ui): prevent hidden dock elements from receiving input - #492

Open
tonoizer wants to merge 2 commits into
devframes:mainfrom
tonoizer:fix/floating-dock-pointer-accessibility
Open

tonoizer wants to merge 2 commits into
devframes:mainfrom
tonoizer:fix/floating-dock-pointer-accessibility

Conversation

@tonoizer

Copy link
Copy Markdown

Summary

The embedded floating dock fades its centered brand mark with opacity, which leaves the decoration eligible for pointer hit testing. Its minimized control wrappers also remain exposed to accessibility queries and keyboard focus after pointer events are disabled.

  • Make the decorative brand mark ignore pointer input and hide it from accessibility tools.
  • Make both the Unauthorized controls and trusted dock controls inert and aria-hidden while minimized.
  • Keep the dock expanded while a control holds keyboard focus, so inactivity cannot remove focus during keyboard use.
  • Add browser regressions for horizontal and vertical center clicks, the shadow-root hit stack, hidden controls, tab order, focus across inactivity, hover restoration, and dragging. The tests use the real embedded custom element and mock only its transport context.

Testing

  • pnpm lint
  • pnpm knip
  • pnpm test --run: 1,847 passed, 26 skipped; no type errors
  • pnpm typecheck: 43 tasks passed
  • pnpm build: 29 tasks passed
  • pnpm exec playwright test --workers=4: all 31 Chromium tests passed
  • All 10 new dock tests passed three times with four parallel workers (30 passes).
  • Independent review, including a second review after adding focus retention.

Validation ran on Windows with Node 24.19.0 and the repository's pnpm 12.18.0. The unit suite used a temporary directory outside the user-home tree so package-manager detection in the existing onboarding tests did not inherit a home-level Yarn configuration.

Risks

Runtime browser coverage is Chromium-only. The focused fixture exercises the shared embedded dock directly; it does not add separate React and Vue application fixtures. Existing opacity transitions, hover reveal, and dragging remain covered.

@vercel

vercel Bot commented Nov 13, 2026

Copy link
Copy Markdown

@tonoizer is attempting to deploy a commit to the NuxtLabs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

👁️‍🗨️ Review this pull request with grouped, summarized diffs at:
👉 https://pulls.review/gh/devframes/devframe/492?from=github-actions[bot]

raw result

💭 analyzed by vercel-ai-gateway/anthropic/claude-sonnet-5
🕰️ 2026-11-16 06:32 UTC
🔗 head 15f8d27
🤖 automated by pulls.review

{
  "headSha": "15f8d27414c1c9c0a557f105d67fa9a749633137",
  "result": {
    "overallSummary": "Fixes two accessibility/input bugs in the floating dock: a decorative brand mark that intercepted pointer events despite fading out, and minimized controls that stayed reachable by assistive tech, tab order, and (via the inactivity timeout) keyboard focus. Adds a dedicated Playwright fixture/spec exercising the real embedded dock to lock in the fix across layouts and auth states.",
    "groups": [
      {
        "key": "dock-fix",
        "label": "Dock focus/pointer fix",
        "summary": "Makes the decorative brand mark ignore pointer input and hide it from assistive tech, marks minimized dock controls `inert`/`aria-hidden`, and keeps the dock expanded while a control retains keyboard focus so inactivity can't steal focus.",
        "category": "ui",
        "filePaths": [
          "packages/hub-ui/src/client/components/dock/Dock.vue"
        ],
        "critical": true,
        "lineNotes": [
          {
            "path": "packages/hub-ui/src/client/components/dock/Dock.vue",
            "side": "additions",
            "line": 51,
            "text": "New `isFocused` tracks focus-within the dock so minimization is suppressed while a control inside it has keyboard focus."
          }
        ]
      },
      {
        "key": "e2e-tests",
        "label": "Floating dock e2e tests",
        "summary": "Adds a Playwright fixture and browser regression tests covering center-click hit testing, shadow-root hit stacking, hidden-control accessibility/tab order, focus retention across inactivity, hover restoration, and dragging; knip.jsonc is updated to recognize the new fixture entry point loaded only via its HTML script tag.",
        "category": "tests",
        "filePaths": [
          "tests/e2e/floating-dock.spec.ts",
          "tests/e2e/_support/floating-dock/index.html",
          "tests/e2e/_support/floating-dock/main.ts",
          "knip.jsonc"
        ],
        "fileNotes": [
          {
            "path": "tests/e2e/floating-dock.spec.ts",
            "text": "Uses the real embedded custom element (via vite.embedded.config.ts) with a mocked transport context, exercising both unauthorized and trusted dock variants in horizontal and vertical layouts."
          }
        ]
      }
    ],
    "schemaVersion": 1,
    "source": "llm",
    "generatedAt": "2026-11-16T06:32:33.780Z",
    "model": "vercel-ai-gateway/anthropic/claude-sonnet-5",
    "locale": "en"
  }
}

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants