Repository navigation
fix: keep readme-weaver partials out of the scan and the auto-commit - #13
Merged
Merged
Conversation
Check out devops-roast/.github into a hidden .readme-weaver-partials directory and add it to .git/info/exclude. Previously it was checked out into ./partials, so readme-weaver also processed partials/README.md (whose include path does not resolve against the base directory) and crashed, and git-auto-commit-action would have committed the checkout as an embedded repository.
3 of 5 tasks
v0.1.2 produces mdformat-stable output, so readme-weaver and pre-commit no longer rewrite each other's auto-commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
readme-weaverreusable workflow could not succeed in any repository:devops-roast/.githubinto./partials, inside the calling repository. readme-weaver scans**/*.mdfrom the workspace root, so it also processedpartials/README.md. That file's include path (common-markdown/sponsorship.md) is relative to the.githubrepo root, not toREADME_WEAVER_BASE, so the run failed withFileNotFoundError ... partials/common-markdown/common-markdown/sponsorship.md.git-auto-commit-action(defaultfile_pattern: .) would have committedpartialsinto the calling repo as an embedded git repository (gitlink).Changes:
.readme-weaver-partialsdirectory. Python'sglob('**/*.md')skips hidden directories, so only the calling repo's markdown is processed..git/info/excludeso the auto-commit never picks it up.actions/checkoutSHA as the other steps.Tested end to end from devops-roast/pre-commit-hooks#8, which temporarily points at this branch.
Definition of Done