Skip to content

feat: Introduce new limits - #460

Open
michael-weigelt wants to merge 2 commits into
mainfrom
mwe/limits
Open

michael-weigelt wants to merge 2 commits into
mainfrom
mwe/limits

Conversation

@michael-weigelt

Copy link
Copy Markdown

No description provided.

@michael-weigelt
michael-weigelt requested review from a team as code owners November 16, 2026 16:03
Copilot AI balanced review requested due to automatic review settings November 16, 2026 16:03
@github-actions github-actions Bot added the interface-spec Changes to the IC interface specification label Nov 16, 2026
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

🤖 Here's your preview: https://dpfyp-oaaaa-aaaam-ahcqa-cai.icp0.io

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The new 1,100-export and 200-import rejection thresholds lack authoritative sources or validator implementation evidence, requiring protocol maintainer confirmation of their values and enforcement scope.

No open issues 🎉

What changed in this PR

This documentation-only PR adds WebAssembly module limits to the ICP canister interface specification.

Changes:

  • Documents a maximum of 1,100 total exports.
  • Documents a maximum of 200 total imports.
  • Updates list punctuation to incorporate the new constraints.
File Description
docs/​references/​ic-interface-spec/​canister-interface.md Adds total export and import limits to the module requirements.

Review effort: Balanced

@mraszyk mraszyk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also update the changelog putting November 30 as the release date (when this change is expected to hit all subnets)? Then I'll approve on that day and merge the PR.

Copilot AI balanced review requested due to automatic review settings November 16, 2026 16:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the documentation-only update specifying canister WebAssembly import and export limits.

No open issues 🎉

Review effort: Balanced

aodl pushed a commit to aodl/ic that referenced this pull request Nov 16, 2026
Limits the number of exports a module may have (beyond the 1000 exported
functions).

This new limit is also added to the [interface
spec](dfinity/developer-docs#460).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

interface-spec Changes to the IC interface specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants