Repository navigation
Drop the stale homepage browser-proof spec rule and correct website comments left by the homepage rework - #1873
Open
dormouse-bot wants to merge 1 commit into
Open
dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
…e homepage rework left stale The homepage section with the authored dor ensure / agent-browser transcript was removed, so its spec section and rationale entry govern nothing. The desktop playground seeds only terminals again, the music-video framing serves no seeded pane, and DemoScene has no opened-after-paint field.
Deploying mouseterm with
|
| Latest commit: |
ddb5d31
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1b1f7c5f.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-website-spec-drift.mouseterm.pages.dev |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes a spec rule that no longer governs anything and corrects three statements the recent homepage and playground rework left stale. Docs and comments only, so there's no regression test.
docs/specs/website-docs.md→ "Homepage browser proof" required the homepage's authoreddor ensure/dor agent-browser opentranscript to carry an "authored and untested" source comment. Homepage: the real app in VS Code mockups, new ports and copy-paste sections, and the playground's L-shape #1866 removed that section fromwebsite/src/pages/Home.tsx, transcript and comment included, so the rule and its rationale entry are deleted.docs/specs/tutorial.mdsaidDESKTOP_PANESowns "each terminal seed's id", implying a non-terminal seed. That was true only while the desktop seeded a music-video pane. The three seeds inwebsite/src/lib/playground-desktop-layout.tsare terminals again, so it reads "each seed's" once more.playgroundIframeUrl(website/src/lib/playground-fs/tool-control.ts) said it frames the video embed "for its own pane". No seeded pane uses it now (Pocket's video Session rendersMusicVideoFramedirectly), so the comment names the embed URL instead, matching the spec's "for its URL".scenes.tssaid a demo scene includes "anything opened once they have painted".DemoScenehas no such field; the only post-paint behavior iscontextTour, which the comment now names.spec-lint,md-unwrap, andpublic-docs-lintpass locally.