Repository navigation
skills(running-tend): run only touched vscode-ext tests, since the sandbox refuses Unix sockets - #1875
Open
dormouse-bot wants to merge 1 commit into
Open
skills(running-tend): run only touched vscode-ext tests, since the sandbox refuses Unix sockets#1875dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
Deploying mouseterm with
|
| Latest commit: |
e759db8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e2267410.mouseterm.pages.dev |
| Branch Preview URL: | https://daily-review-runs-4492020794.mouseterm.pages.dev |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
running-tendnote that the tend sandbox refusesAF_UNIXsockets, so fourvscode-extsuites fail on every change there, and tells sessions to run only the touched test files instead of the whole package suite. Last night's nightly (44915005808, 54 min) spent about 30 of those minutes running the fullvscode-extsuite three times, once on a stashed baseline, to establish that 90 failures predated its one-file change for #1872.Reproduced in this session: in the sandbox,
net.createServer().listen(<path>)fails withEAFNOSUPPORTwhile a loopback TCP listen succeeds, andvitest run test/peer-link.test.tsalone reports 47 of 51 tests failed after 4.5 min, the first withlisten EAFNOSUPPORTon its.sockpath. CI runs these suites outside the sandbox, so nothing is lost by skipping them locally. Upstream documents the restriction as intended (max-sixty/tend#1313).Where the nightly's time went
From the session log of run 44915005808:
pnpm testinvscode-ext(8.5 min): peer-link handshake testsTest timed out in 5000mspnpm exec vitest run(7 min):90 failed | 189 passed90 failed | 188 passedon both, failures inburrow(25),outbound(9),peer-endpoint(9),peer-link(47)By contrast, running
test/pty-manager.test.tsalone at 14:51:25 took 247 ms (red before the fix, as intended). The PR it opened (#1872) is green.Tracking: #1492.