Skip to content

skills(running-tend): run only touched vscode-ext tests, since the sandbox refuses Unix sockets - #1875

Open
dormouse-bot wants to merge 1 commit into
mainfrom
daily/review-runs-44920207945-unix-sockets
Open

dormouse-bot wants to merge 1 commit into
mainfrom
daily/review-runs-44920207945-unix-sockets

Conversation

@dormouse-bot

Copy link
Copy Markdown
Collaborator

Adds a running-tend note that the tend sandbox refuses AF_UNIX sockets, so four vscode-ext suites fail on every change there, and tells sessions to run only the touched test files instead of the whole package suite. Last night's nightly (44915005808, 54 min) spent about 30 of those minutes running the full vscode-ext suite three times, once on a stashed baseline, to establish that 90 failures predated its one-file change for #1872.

Reproduced in this session: in the sandbox, net.createServer().listen(<path>) fails with EAFNOSUPPORT while a loopback TCP listen succeeds, and vitest run test/peer-link.test.ts alone reports 47 of 51 tests failed after 4.5 min, the first with listen EAFNOSUPPORT on its .sock path. CI runs these suites outside the sandbox, so nothing is lost by skipping them locally. Upstream documents the restriction as intended (max-sixty/tend#1313).

Where the nightly's time went

From the session log of run 44915005808:

  • 14:51:46 pnpm test in vscode-ext (8.5 min): peer-link handshake tests Test timed out in 5000ms
  • 15:00:18 pnpm exec vitest run (7 min): 90 failed | 189 passed
  • 15:07:41 the same run, then again with the change stashed (15 min): 90 failed | 188 passed on both, failures in burrow (25), outbound (9), peer-endpoint (9), peer-link (47)

By contrast, running test/pty-manager.test.ts alone at 14:51:25 took 247 ms (red before the fix, as intended). The PR it opened (#1872) is green.

Tracking: #1492.

@dormouse-bot dormouse-bot added the review-runs Opened by the review-runs sweep label Nov 21, 2026
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: e759db8
Status: ✅  Deploy successful!
Preview URL: https://e2267410.mouseterm.pages.dev
Branch Preview URL: https://daily-review-runs-4492020794.mouseterm.pages.dev

View logs

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-runs Opened by the review-runs sweep

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant