Repository navigation
Say a request holds about 18,600 renders, counting its stories' key statements - #92
Open
selfie-bot wants to merge 1 commit into
Open
selfie-bot wants to merge 1 commit into
selfie-bot wants to merge 1 commit into
Conversation
…tatements The comments at STATEMENTS_PER_REQUEST and the two-request test still said 19,600, from before each request also carried a key statement per 1,000 stories (df1ba5d). docs/specs/renders.md -> Requests and the test's own 18,620 already say the current figure.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two comments said one request of 400 statements holds 19,600 renders. Since df1ba5d, each request also carries one key statement per 1,000 stories, so the real figure is about 18,600. The comments are at
store/src/core/chunks.tsbySTATEMENTS_PER_REQUEST, and above thecrashes partwaytests instore/test/render-batches.test.ts.docs/specs/renders.md→ Requests already says "about 18,600". The test also expects 18,620 renders in the first request: 20 statements key the 20,000 stories, and 380 statements hold 49 renders each.This changes comments only, so there's no regression test. The code and the assertions are unchanged.