Skip to content

Say a request holds about 18,600 renders, counting its stories' key statements - #92

Open
selfie-bot wants to merge 1 commit into
mainfrom
fix/request-capacity-comment
Open

selfie-bot wants to merge 1 commit into
mainfrom
fix/request-capacity-comment

Conversation

@selfie-bot

Copy link
Copy Markdown
Collaborator

Two comments said one request of 400 statements holds 19,600 renders. Since df1ba5d, each request also carries one key statement per 1,000 stories, so the real figure is about 18,600. The comments are at store/src/core/chunks.ts by STATEMENTS_PER_REQUEST, and above the crashes partway tests in store/test/render-batches.test.ts. docs/specs/renders.md → Requests already says "about 18,600". The test also expects 18,620 renders in the first request: 20 statements key the 20,000 stories, and 380 statements hold 49 renders each.

This changes comments only, so there's no regression test. The code and the assertions are unchanged.

…tatements

The comments at STATEMENTS_PER_REQUEST and the two-request test still said
19,600, from before each request also carried a key statement per 1,000
stories (df1ba5d). docs/specs/renders.md -> Requests and the test's own
18,620 already say the current figure.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant