Skip to content

Enable Claude review and auto-approve (dry run) - #71

Closed
ivpusic wants to merge 1 commit into
mainfrom
ivan/claude-auto-approve
Closed

ivpusic wants to merge 1 commit into
mainfrom
ivan/claude-auto-approve

Conversation

@ivpusic

@ivpusic ivpusic commented Nov 20, 2026

Copy link
Copy Markdown
Member

What & why

Opts the CLI repo in to Claude review and auto-approve, following the opt-in steps and how spellbook (also public) and core call the shared workflow.

  • AGENTS.md (new): a short guide plus the "Review risk boundaries" Claude judges each PR against. Human-only: .github/, install.sh, .goreleaser.yml, AGENTS.md; authconfig/ (API key storage); tracking/ (telemetry); new hosts for the API key; breaking changes to commands, flags, defaults, exit codes or -o json keys; new dependencies, major bumps, the Go version and non-proxy sources; deleting a test whose subject stays.
  • .github/workflows/claude.yml: calls duneanalytics/actions/.github/workflows/claude.yml@main with auto-approve: true and dry-run: true, so for now it only posts decision comments. deny-paths hard-blocks the file-level boundaries above.
  • Public repository, so it runs on ubuntu-latest (the self-hosted group refuses public repos) and skips PRs from forks, which get no secrets or OIDC token. secrets are passed by name, as in spellbook.

Remaining steps

  1. Allowlist: the companion PR in duneanalytics/actions adds duneanalytics/cli to .github/auto-approve-allowlist.txt; it needs the VP of Engineering's review. Until it merges, every decision comment says the repository is not on the allowlist, and the job stays green.
  2. Dry run off: after a few decision comments look right, a one-line PR sets dry-run: false.
  3. No cooldown step: the repo has no Renovate or Dependabot.

Verification

  • actionlint is clean.
  • This PR runs the new workflow on itself (pull_request uses the head's workflow file): its run shows whether ANTHROPIC_API_KEY reaches this repo, and the review job should post comments. The decision comment will say "not on the allowlist" and that nothing was approved, because .github/* and AGENTS.md are in deny-paths.

Blast radius: PRs in this repo get Claude review comments and a decision comment. Nothing is approved until both the allowlist PR merges and dry-run is switched off.

Adds AGENTS.md with the review risk boundaries Claude judges PRs against, and
a caller of the shared Claude workflow in duneanalytics/actions with
auto-approve in dry-run mode. Approvals also need duneanalytics/cli on the
allowlist in duneanalytics/actions.
@ivpusic
ivpusic marked this pull request as draft November 20, 2026 09:59
@ivpusic
ivpusic marked this pull request as ready for review November 20, 2026 10:02
@ivpusic
ivpusic requested a review from charisra November 20, 2026 10:02

ivpusic commented Nov 20, 2026

Copy link
Copy Markdown
Member Author

@norbertdurcansk @charisra could you review? Open question first: duneanalytics/actions is internal, and a public repo can only call public reusable workflows, so this caller fails to start (spellbook has the same problem). The AGENTS.md risk boundaries apply either way. For the workflow, we need either a public home for the shared Claude workflow and action, or a decision to run review only here.

@ivpusic ivpusic closed this Nov 20, 2026
@ivpusic
ivpusic deleted the ivan/claude-auto-approve branch November 20, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant