Repository navigation
Conversation
Adds AGENTS.md with the review risk boundaries Claude judges PRs against, and a caller of the shared Claude workflow in duneanalytics/actions with auto-approve in dry-run mode. Approvals also need duneanalytics/cli on the allowlist in duneanalytics/actions.
ivpusic
marked this pull request as draft
November 20, 2026 09:59
ivpusic
marked this pull request as ready for review
November 20, 2026 10:02
Member
Author
|
@norbertdurcansk @charisra could you review? Open question first: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Opts the CLI repo in to Claude review and auto-approve, following the opt-in steps and how
spellbook(also public) andcorecall the shared workflow.AGENTS.md(new): a short guide plus the "Review risk boundaries" Claude judges each PR against. Human-only:.github/,install.sh,.goreleaser.yml,AGENTS.md;authconfig/(API key storage);tracking/(telemetry); new hosts for the API key; breaking changes to commands, flags, defaults, exit codes or-o jsonkeys; new dependencies, major bumps, the Go version and non-proxy sources; deleting a test whose subject stays..github/workflows/claude.yml: callsduneanalytics/actions/.github/workflows/claude.yml@mainwithauto-approve: trueanddry-run: true, so for now it only posts decision comments.deny-pathshard-blocks the file-level boundaries above.ubuntu-latest(the self-hosted group refuses public repos) and skips PRs from forks, which get no secrets or OIDC token.secretsare passed by name, as inspellbook.Remaining steps
duneanalytics/actionsaddsduneanalytics/clito.github/auto-approve-allowlist.txt; it needs the VP of Engineering's review. Until it merges, every decision comment says the repository is not on the allowlist, and the job stays green.dry-run: false.Verification
pull_requestuses the head's workflow file): its run shows whetherANTHROPIC_API_KEYreaches this repo, and the review job should post comments. The decision comment will say "not on the allowlist" and that nothing was approved, because.github/*andAGENTS.mdare indeny-paths.Blast radius: PRs in this repo get Claude review comments and a decision comment. Nothing is approved until both the allowlist PR merges and
dry-runis switched off.