Repository navigation
Bump duneapi-client-go to v0.7.1 - #72
Merged
Merged
Conversation
v0.7.1 returns the decode error from getResults (duneapi-client-go#33): an unreadable results page now fails instead of being ignored, so a paginated result can no longer look complete with only its earlier pages. Amp-Thread-ID: https://ampcode.com/threads/T-01a1f35e-4422-71d4-a903-056e89e15547 Co-authored-by: Amp <amp@ampcode.com>
norbertdurcansk
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Bumps duneapi-client-go from v0.7.0 to v0.7.1, which has one change:
getResultsreturns the error when a results response can't be decoded (duneapi-client-go#33). Before, the error was ignored, so if a later page of a paginated result failed to decode,execution resultsandquery runcould print the earlier pages' rows as if they were the whole result.go.mod/go.sum: the SDK bump;go mod tidychanges nothing else.flake.nix: newvendorHash, computed as the NAR hash ofgo mod vendor(nix hash path), the method that reproduces main's current hash.Tests
go vet ./...andgo test -race ./...pass.nix buildcouldn't run in the agent sandbox; thenixCI jobs build the flake and check the hash.Blast radius: CLI users see an error instead of partial rows when the API returns an unreadable results page. Follows with a v0.1.23 release.