Repository navigation
dataflow docstrings: cross-check against the current backend source - #13
Merged
Merged
Conversation
Re-read the dataflow routes on the backend branch closest to live. The listings, paging, create and delete behave as before. Corrections: dataflow_datasets now says an unknown dataflow id answers 500 (the access check fails first, seen live), not an empty 200, and lists the admin and national coordinator access; dataflows lists the filters keys the backend reads; delete_dataflow notes that a Business dataflow needs an admin. Adds a mocked test for the 500 and regenerates the reference page.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-read the
dataflowresource's routes against the backend branch closest to live. Behaviour matches the client; this PR fixes and extends the docstrings only.dataflow_datasets: an unknown dataflow id answers 500 (ServerError). The access check fails before the lookup, as seen live. The docstring previously said this case gave an empty 200 /None. It now also lists the admin and national coordinator access, and says a requester sees all representatives.dataflows: documents thefilterskeys the backend reads, includingrole, which keeps only dataflows where the user holds that role.delete_dataflow: a Business dataflow needs an admin (403 otherwise).docs/reference/dataflow.md; CHANGELOG entry.ruff, mypy and pytest (522) pass locally.