Skip to content

ci: split ensure-orgs runs and tests - #1364

Open
nschonni wants to merge 1 commit into
github:gh-pagesfrom
nschonni:ensure-ci-testing
Open

nschonni wants to merge 1 commit into
github:gh-pagesfrom
nschonni:ensure-ci-testing

Conversation

@nschonni

Copy link
Copy Markdown
Contributor

Commented on the PR that introduced the test, but didn't have a good solution for it not running on every PR.
This uses tj-actions/changed-files and runs the normal script or the test version, depending on the files that are touched.
Also made sure that the cron should always run the script, but didn't add anything for the workflow_dispatch

Copilot AI adaptive review requested due to automatic review settings November 17, 2026 03:14
ensure:
runs-on: ubuntu-24.04
needs: changed_files
if: needs.changed_files.outputs.run_ensure == 'true' || github.event.schedule == '23 6 1 * *'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probaby needs an extra OR for the workflow_dispatch to always run this task

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The changed-file filters skip both checks for workflow-only changes and unnecessarily run unit tests for data-only changes.

2 open issues
What changed in this PR

This PR separates organization validation from its unit tests, using changed-file filters to control which CI jobs run.

Changes:

  • Adds a changed-files job with separate outputs for validation and tests.
  • Splits the script and unit tests into independent Ruby jobs.
  • Adds a schedule condition to run validation on the monthly cron.
File Description
.github/​workflows/​ensure-orgs.yml Adds file-based job selection and separates organization validation from unit tests.

Review effort: Balanced (adaptive)

Comment thread .github/workflows/ensure-orgs.yml Resolved
Comment thread .github/workflows/ensure-orgs.yml Resolved

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants