Repository navigation
Conversation
nschonni
commented
Nov 17, 2026
| ensure: | ||
| runs-on: ubuntu-24.04 | ||
| needs: changed_files | ||
| if: needs.changed_files.outputs.run_ensure == 'true' || github.event.schedule == '23 6 1 * *' |
Contributor
Author
There was a problem hiding this comment.
This probaby needs an extra OR for the workflow_dispatch to always run this task
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The changed-file filters skip both checks for workflow-only changes and unnecessarily run unit tests for data-only changes.
2 open issues
What changed in this PR
This PR separates organization validation from its unit tests, using changed-file filters to control which CI jobs run.
Changes:
- Adds a changed-files job with separate outputs for validation and tests.
- Splits the script and unit tests into independent Ruby jobs.
- Adds a schedule condition to run validation on the monthly cron.
| File | Description |
|---|---|
.github/workflows/ensure-orgs.yml |
Adds file-based job selection and separates organization validation from unit tests. |
Review effort: Balanced (adaptive)
nschonni
force-pushed
the
ensure-ci-testing
branch
from
November 17, 2026 04:14
7b2e03d to
75a8418
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Commented on the PR that introduced the test, but didn't have a good solution for it not running on every PR.
This uses
tj-actions/changed-filesand runs the normal script or the test version, depending on the files that are touched.Also made sure that the
cronshould always run the script, but didn't add anything for theworkflow_dispatch