Repository navigation
Queue clips with drawings and caption them like drawings - #301
Merged
Merged
Conversation
Clips used their own video queue and worker, so they rendered on GPU1 next to drawings and VIP users had no priority for them. Clips now join the drawing queues: VIP clips go to image-vip with the VIP priority, the rest to image-regular, and the image generation workers render them in queue order through a video runner. Taskman arbitration treats VideoGen as accelerator work, so a clip and a drawing never run side by side. Scheduling uses the drawing plan: the per-user active limit counts drawings and clips together, and the drawing frequency limit, enqueue limit and queue-position notice apply to clips. The clip caption now uses the drawing caption: title, author with the VIP badge, #nsfw for adult clips and the support link, sent as HTML. A short `!видео ...` request keeps the user's words as the title, and an empty dialog caption is sent back for a retry, as for drawings.
A VideoGen ticket is accelerator work. Left pending after video generation is switched off, it would hold back every drawing ranked below it. Image generation workers now always take clips and fail them when no video runner is configured.
Owner
Author
|
Danger warning about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
videoqueue and worker. They rendered on GPU1 at the same time as drawings, and VIP users got no priority for clips.Shared queue
make_videouses the drawing queue plan. VIP users go toimage-vipwithIMAGE_VIP_PRIORITY; everyone else goes toimage-regularwith the default priority.ImageGenandVideoGentickets in queue order. They hand a clip to aVideoJobRunner(the FastFrames pipeline). The standalone video worker and thevideoqueue are removed. On prod thevideoqueue has no pending or processing tickets.VideoGen, and VIP clips get the VIP priority floor. A clip and a drawing therefore never render side by side, and a waiting VIP clip holds back regular work in the same way as a VIP drawing.Captions
build_image_generation_caption, the same as a drawing caption: title in<code>or an expandable quote, "за авторством" with the VIP badge,#nsfw 18+for adult clips, and the support link. It is sent with HTML parse mode.!видео …request (10 words or fewer) keeps the user's words as the title, the same as!нарисуй.video_caption_requiredfor a retry, the same asimage_caption_required. The tool argument and the system prompt rule now namemake_video.Tests
cargo fmt --all;cargo clippy --workspace --all-targets -- -D warnings.cargo test:openplotva-taskman69 passed,openplotva-dialog110 passed,openplotva-prompts10 passed,openplotva-llm236 passed,openplotva-app1465 passed.#nsfw, brief fallback, HTML parse mode;video_caption_requiredand the verbatim shortcut title.