Repository navigation
Finish the LLM run timeline and keep its waterfall inside the panel - #302
Open
iamwavecut wants to merge 3 commits into
Open
iamwavecut wants to merge 3 commits into
iamwavecut wants to merge 3 commits into
Conversation
The run buffer attached a tool result to whatever round came last. For understand_media that is the auxiliary vision call the tool itself made, so the admin waterfall started the tool at the end of that call and drew it past the end of the run. Tool results and sent markers now go to the latest non-auxiliary round, tool calls carry their wall-clock start (parallel understand_media calls are recorded only after the batch), and one-off runs start when their call began rather than when it returned.
The waterfall draws each round, the tools it called and the auxiliary calls those tools made from their real start and end, clips every bar to its track, and adds the queue before the run, the preparation before the first call, a time scale and per-actor totals. Timeline steps follow start time, tools resolve their names by tool_call_id, and step colours follow the actor: model, tools, people, memory, runtime. Major steps are raised tone blocks; tools, auxiliary calls and chat messages are rows on the spine. The header and the waterfall reflow on narrow screens.
Owner
Author
|
Keeping this as one PR. 3888 of the 4079 changed lines are the admin page ( |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The LLM Dialogs run detail becomes a timeline with a "Where the time went" waterfall and a context rail. The waterfall no longer draws bars past its panel.
/admin/api/llm/dialogs/detailpayload.pl-constellation), persona and chat settings, run facts.--c-bg-raisedtoken gives raised blocks a surface that differs from the card in both themes.Why the waterfall overflowed
RuntimeLlmRunBuffer::record_tool_resultattached a tool result to the run's latest round. Forunderstand_media, that round is the auxiliary vision call the tool itself made. The waterfall started the tool at the end of that call, and nothing clipped the bar. In one production run, three parallelunderstand_mediacalls ended 20% past the end of the run.Backend changes
RunToolCall.started_atrecords the wall-clock start. Parallelunderstand_mediacalls are recorded after the whole batch ends, so their start comes from the parallel executor.round.at - duration_ms.round.atis stamped when the call returns, so these runs showed a wall time of 1 ms.TurnContextArtifact.chat_titlefills the run origin's chat title.Contract
These changes are additive.
tool_calls[].started_atappears in the admin detail JSON and thellmRunsGraphQL JSON.chat_titleusesserde(default). No routes, IDs or existing fields change.Verification
cargo fmt --all -- --check,cargo clippy --workspace --all-targets -- -D warningscargo test -p openplotva-web: guard tests and asset hashes, 21 passedcargo test -p openplotva-app --lib -- runtime_llm_runs dialog_turn: 44 passed, including the newtools_and_sent_markers_skip_nested_auxiliary_roundsand the one-off start assertionEvery inline admin script and
components.jspassnode --check.Live production payloads, rendered by the branch's page without a deploy, checked at 2871, 1440, 768 and 390 px, in the dark and light themes, collapsed and fully expanded:
Cases covered: parallel media tools with vision, vision before the first round,
send_message+web_search, a running run, one-offmemory_subject_merge/optimize_prompt, and a failed run made from a copy of a real run in the browser.tools/service-smoke.web-ui.spec.jsgains real timings and waterfall assertions. The same assertions were checked in the browser against this fixture. The Docker smoke itself was not run.