Skip to content

Fix PHP downstream rebuild dispatch coverage and failures - #138

Merged
dbpolito merged 3 commits into
masterfrom
fix/downstream-php-dispatch
Nov 14, 2026
Merged

dbpolito merged 3 commits into
masterfrom
fix/downstream-php-dispatch

Conversation

@dbpolito

@dbpolito dbpolito commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Make downstream dispatch failures visible and record outcomes without claiming downstream build completion.

PHP owns the weekly schedule and notifies WordPress, SQL Server, PHPQA and Swoole after publication. OCI8 is notified only by Swoole after all its parents are published; it is not a parallel direct PHP recipient. Downstream cron schedules are removed in their companion PRs.

Use an optional dedicated DISPATCH_TOKEN override, falling back to the existing inherited WORKFLOW_TOKEN. No new credential setup is normally needed; secret metadata cannot establish expiration or cross-repository permissions. If neither secret is available, fail visibly after image publication. No secret values or credentials were changed.

Also fix the template consistency check: the packaged fwd Blade cache cannot run as an arbitrary UID (reproduced locally); use the default container user. Regeneration leaves tracked image sources unchanged.

Related to #137. Merge downstream receivers first, then merge this sender and verify real dispatch/publication. PR validation does not establish that published derived images are patched.

@dbpolito

Copy link
Copy Markdown
Member Author

Rollout prerequisite confirmed from the latest scheduled default-branch build: downstream job log shows an empty DISPATCH_TOKEN and Downstream builds skipped: configure DISPATCH_TOKEN..., despite the job being green.

Before relying on this sender, configure/verify an appropriately scoped dispatch token for all five downstream repositories, and land their receivers first. This PR correctly makes missing-token failures visible, but does not create credentials or prove delivery/completion. Weekly receiver fallbacks remain important. No credentials were changed during this work.

@dbpolito

Copy link
Copy Markdown
Member Author

Correction to the earlier rollout note: a new DISPATCH_TOKEN is not normally required. This repository already inherits WORKFLOW_TOKEN; commit 5d40207 selects secrets.DISPATCH_TOKEN || secrets.WORKFLOW_TOKEN for both the credential check and dispatch action. A dedicated DISPATCH_TOKEN remains an optional least-privilege override. Secret metadata confirms availability, not token expiration or cross-repository permissions. Neither secret values nor scopes were inspected or changed, and no real dispatch was sent. Actionlint and mock tests cover dedicated override, inherited fallback, dedicated-only, and neither-token failure. README and PR description now reflect this behavior.

@dbpolito
dbpolito merged commit b6257f7 into master Nov 14, 2026
17 checks passed
@dbpolito
dbpolito deleted the fix/downstream-php-dispatch branch November 14, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant