Skip to content

TPT-4130: add support for valkey as a new managed database - #759

Draft
anmsharm1 wants to merge 3 commits into
linode:devfrom
anmsharm1:DBAAS1-1818
Draft

anmsharm1 wants to merge 3 commits into
linode:devfrom
anmsharm1:DBAAS1-1818

Conversation

@anmsharm1

Copy link
Copy Markdown

📝 Description

This PR adds support for Valkey as a new managed database type in linode python sdk

What does this PR do and why is this change necessary?
TPT-4130 is tracking InnerSource DX tools initiative changes covering Managed Database Valkey as an addition to the list of supported database engine type. The support for Valkey is already released to APIv4 and is live in production (as a limited availability offering). Adding this support in linodeapiv4-python sdk will help us prepare to announce Valkey as GA/

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?

  • Unit test coverage has been updated
# Install development dependencies (if needed)
make dev-install

# Run the focused Valkey unit tests
python -m pytest test/unit/groups/valkey_test.py test/unit/objects/valkey_test.py -q

# Run the full mocked unit suite
make test-unit

# Check the Valkey integration tests without making live API calls
python -m pytest test/integration/models/database/test_valkey.py -q

How do I run the relevant unit/integration tests?
I setup LINODE_TOKEN env var and ran, based on documentation:

SKIP_E2E_FIREWALL=1 RUN_VALKEY_DB_TESTS=true python -m pytest test/integration/models/database/test_valkey.py -q

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant