Repository navigation
Conversation
An empty GLib.Bytes is truthy, so the 'if bytes_read' check never caught EOF on stdin and the read was queued again right away. When mintupdate went away the worker kept spinning on zero-byte reads at high CPU. Quit on a zero-sized read instead of reading again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
once mintupdate exits or closes stdin,
message_from_updatergets an emptyGLib.Bytes, which is still truthy in python, so it just queued another read and the worker spun on EOF forever. it now checksget_size() == 0and quits, same as what the SIGTERM fromterminate_helperdoes. added a test for it intests/, closes #1041