Repository navigation
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
maxminddb 3.3.0 fixes C extension memory-safety and free-threading bugs, and raises InvalidDatabaseError for more corrupt databases. With it, geoip2.database.Reader accepts a binary file object in MODE_AUTO, so the docstring now says so. 3.3.0 also narrows the type of open_database's database argument, so mypy rejected our IO[str] annotation. Use maxminddb.types.DatabaseSource instead. A text file object never worked at runtime. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
d20fc5f to
45da970
Compare
Release 5.4.0. The only user-facing change is the higher
maxminddbfloor. maxminddb 3.3.0 givesgeoip2.database.Readernew behavior (a binary file object works inMODE_AUTO), so this is a minor release rather than a patch.This PR has three commits:
InvalidDatabaseErrorfor more corrupt databases. The commit also:uv.lock.Readerdocstrings to match maxminddb 3.3.0. A binary file object works withMODE_FDorMODE_AUTO, andMODE_MMAP,MODE_FILE, andMODE_MEMORYalso accept a file descriptor. The old text said that onlyMODE_FDtakes a file object, and it called that object a file descriptor.MODE_AUTO.fileishtype hint tomaxminddb.types.DatabaseSource. maxminddb 3.3.0 narrowed the type thatopen_databaseaccepts, so mypy rejected ourIO[str]annotation. A text file object never worked at runtime.mise.lock. uv 0.13.7 → 0.13.8.release.shchecks it.uv run toxpasses locally, including on Python 3.10 to 3.14 and the lint environment.dev-bin/release.shsets the version inpyproject.toml, runs tox, and creates the release. The release workflow publishes to PyPI.Part of STF-2455.
🤖 Generated with Claude Code
Summary by CodeRabbit
maxminddbversion is now 3.3.0.