Skip to content

STF-2455: Release 3.4.0 - #514

Open
oschwald wants to merge 4 commits into
mainfrom
greg/release-3.4.0
Open

oschwald wants to merge 4 commits into
mainfrom
greg/release-3.4.0

Conversation

@oschwald

@oschwald oschwald commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

This PR prepares the 3.4.0 release. It is a minor release because 3.4.0 adds new request inputs (phone and email verification fields) and a new payment processor, all backward compatible. This PR also raises the geoip2 floor to 5.4.0.

Commits:

  • Require geoip2 5.4.0. Each minFraud release requires the latest GeoIP client release. uv.lock moves geoip2 5.3.0 to 5.4.0 and maxminddb 3.0.0 to 3.3.0, because geoip2 5.4.0 requires maxminddb 3.3.0. The commit adds the HISTORY.rst entry "The minimum version of geoip2 is now 5.4.0."
  • Update mise.lock. uv 0.13.7 to 0.13.8. lychee 0.24.2 is still the latest. Locked with mise 2026.11.9, the version CI uses. All 6 platforms and their provenance entries remain.
  • Set the 3.4.0 release date. Adds (2026-11-18) to the heading that dev-bin/release.sh parses.

Verified locally:

  • uv run tox passes on Python 3.10 to 3.14 and lint (256 tests), with uv 0.13.6 and with the locked uv 0.13.8. The tox environments load the maxminddb 3.3.0 C extension.
  • mise run check-links passes with the locked lychee.
  • The regex= block in dev-bin/release.sh parses the new heading: BASH_REMATCH[1] is 3.4.0 and BASH_REMATCH[3] is 2026-11-18.
  • A dry run of the script's version bump plus uv run tox passes and updates the minfraud version in uv.lock.

dev-bin/release.sh sets version in pyproject.toml to 3.4.0, runs uv run tox (which also updates uv.lock), commits, pushes, and creates the v3.4.0 GitHub release. The release workflow then publishes to PyPI.

Part of STF-2455.

🤖 Generated with Claude Code

Copilot AI balanced review requested due to automatic review settings November 17, 2026 23:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0d718fac-ee8a-4604-aa69-ca2168c4cc84
Commits

Reviewing files that changed from the base of the PR and between 3579f98 and 3ae1eed.

Files ignored due to path filters: 2

  • mise.lock is excluded by !**/*.lock
  • uv.lock is excluded by !**/*.lock
Files selected for processing: 2

  • HISTORY.rst
  • pyproject.toml

No actionable comments were generated in the recent review.

Walkthrough

The 3.4.0 changelog entry now has a release date and updated release notes. The minimum geoip2 dependency version increased from 5.3.0 to 5.4.0; its upper bound remains unchanged.

Changes: 3.4.0 release

Layer / File(s) Summary
Finalize release notes and dependency minimum
HISTORY.rst, pyproject.toml
The changelog dates version 3.4.0 and records release notes, including verification inputs, stricter RFC 3339 rejection cases, ryft as a valid payment processor, and the geoip2 minimum version. The project configuration raises that minimum to 5.4.0 and keeps the existing upper bound.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related PRs

Suggested reviewers: horgh

Merge Risk: Minimal · previous review 3579f

This release prep raises the minimum geoip2 version to 5.4.0 and dates the 3.4.0 changelog. No merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "STF-2455: Release 3.4.0" names a release, and the changeset does prepare the 3.4.0 release. The HISTORY.rst heading gains the 2026-11-18 date, and pyproject.toml raises the geoip2 floor for…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "STF-2455: Release 3.4.0" names a release, and the changeset does prepare the 3.4.0 release. The HISTORY.rst heading gains the 2026-11-18 date, and pyproject.toml raises the geoip2 floor for that release. The ticket prefix adds no information, and the title does not say what the release contains (phone and email verification fields, the ryft processor, and the geoip2 bump). The title is therefore partially related to the changeset. It refers to a real part of the change but does not name the main content.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit marks the release date bright,
Then checks the notes by lantern light.
New fields and processors join the page,
While geoip2 steps up a stage.
The bounds stay put; the changelog’s done,
And off hops rabbit, pleased with one.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: caf06d81-952c-4529-b836-08cfd33f996d
Commits

Reviewing files that changed from the base of the PR and between 04ae58d and 3579f98.

Files ignored due to path filters: 2

  • mise.lock is excluded by !**/*.lock
  • uv.lock is excluded by !**/*.lock
Files selected for processing: 2

  • HISTORY.rst
  • pyproject.toml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

oschwald and others added 3 commits November 17, 2026 23:55
Each minFraud release requires the latest GeoIP client release.
geoip2 5.4.0 requires maxminddb 3.3.0, so uv.lock moves both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lock the latest uv (0.13.7 to 0.13.8) before the release. lychee
0.24.2 is still the latest. Locked with mise 2026.11.9, the version CI
uses. All 6 platforms and their provenance entries remain.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dev-bin/release.sh reads the version and date from this heading. The
release happens on 2026-11-18.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 23:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

Copilot AI balanced review requested due to automatic review settings November 18, 2026 00:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

This branch was successfully deployed

1 active deployment
release — 3ae1eed9 Deployed Nov 18, 2026 by oschwald via upload_pypi #867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants