Repository navigation
Companion: preserve queued messages when host writes fail - #3897
Open
cryptomaxsun wants to merge 1 commit into
Open
cryptomaxsun wants to merge 1 commit into
cryptomaxsun wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the head of the Companion offline queue until the transport that requested it accepts the complete frame. A full or disconnected transport can then retry without skipping a message. Direct the sync response to the requesting interface so an unrelated transport cannot affect dequeueing.
Regression scenario: reject a sync response, retry from that client, and verify it receives the same message before the next one.