Skip to content

Restore Embedding package publishing to NuGet.org - #522

Merged
Vladimir Morozov (vmoroz) merged 1 commit into
microsoft:mainfrom
vmoroz:PR/restore-embedding-publish
Nov 20, 2026
Merged

Vladimir Morozov (vmoroz) merged 1 commit into
microsoft:mainfrom
vmoroz:PR/restore-embedding-publish

Conversation

@vmoroz

Copy link
Copy Markdown
Member

Why

The ESRP publishing fix makes the temporary workaround in #519 unnecessary.

What

  • Unconditional publishing: Remove the opt-in parameter and Embedding exclusion so normal NuGet.org releases include Embedding with the other packages.

Testing

NuGet ESRP passed with Embedding included; the restored-default YAML preview matches the enabled-current configuration apart from the removed parameter.

Copilot AI balanced review requested due to automatic review settings November 20, 2026 15:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the change restoring default NuGet.org publishing for the Embedding package.

No open issues 🎉

What changed in this PR

Restores default publishing of the Embedding package to NuGet.org alongside the other packages, removing the temporary workaround now that the ESRP publishing issue is resolved.

Changes:

  • Removes the publishEmbeddingPackage opt-in parameter.
  • Removes the conditional step that excluded Embedding packages from the ESRP submission directory.
File Description
.ado/​release.yml Includes Embedding in normal NuGet.org releases without requiring an opt-in.

Review effort: Balanced

@vmoroz
Vladimir Morozov (vmoroz) merged commit 5b14932 into microsoft:main Nov 20, 2026
17 checks passed
@vmoroz
Vladimir Morozov (vmoroz) deleted the PR/restore-embedding-publish branch November 20, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants