Repository navigation
Restore Embedding package publishing to NuGet.org - #522
Merged
Vladimir Morozov (vmoroz) merged 1 commit intoNov 20, 2026
Merged
Vladimir Morozov (vmoroz) merged 1 commit into
Vladimir Morozov (vmoroz) merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change restoring default NuGet.org publishing for the Embedding package.
No open issues 🎉
What changed in this PR
Restores default publishing of the Embedding package to NuGet.org alongside the other packages, removing the temporary workaround now that the ESRP publishing issue is resolved.
Changes:
- Removes the
publishEmbeddingPackageopt-in parameter. - Removes the conditional step that excluded Embedding packages from the ESRP submission directory.
| File | Description |
|---|---|
.ado/release.yml |
Includes Embedding in normal NuGet.org releases without requiring an opt-in. |
Review effort: Balanced
Jason Ginchereau (jasongin)
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The ESRP publishing fix makes the temporary workaround in #519 unnecessary.
What
Testing
NuGet ESRP passed with Embedding included; the restored-default YAML preview matches the enabled-current configuration apart from the removed parameter.