You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
UriTemplate.match() misparses {;var} when following literal begins with '=' #3852
UriTemplate.match() breaks match(expand(variables)) == variables when a {;var} path-style parameter expression (ifemp = True, RFC 6570 §3.2.7) is immediately followed by a literal that begins with "=" (for example "{;a}=end{+rest}" or "/api{;mode}=fast{/id}").
In src/mcp/shared/uri_template.py (_scan_prefix), the atom.ifemp check runs:
Checking uri.startswith(nxt.text, pos) unconditionally before uri[pos] == "=" handles the empty-value case (a == "" -> ";a=end/x"), except when a equals the stem of nxt.text (a == "end" -> expand() emits ";a=end=end/x"). At pos right after ";a", uri[pos:] is "=end=end/x", which also starts with nxt.text ("=end"). _scan_prefix prematurely treats a as "" and leaves the second "=end" to be absorbed by a downstream greedy variable {+rest} (or fails suffix matching when no greedy variable follows).
I'd like to take this issue and ask to be assigned.
UriTemplate.match() currently misparses {;var} when the following literal starts with =, because the empty-value check in _scan_prefix can treat that literal as an empty path-style value. I plan to fix that check in src/mcp/shared/uri_template.py and add tests so match(expand(variables)) == variables holds for this case (including examples like {;a}=end{+rest}).
Please assign this issue to me. Once it is assigned, I will open a PR with Fixes #3852, as described in the contributing guide (external PRs are reviewed when assigned or labeled help wanted).
Confirmed on main (77001c9). One nuance: ;a=end=end/x is genuinely ambiguous for {;a}=end{+rest}, since {a: "", rest: "=end/x"} expands to the same string, so the fix is really about consistency: the suffix scan already prefers ;name=value ({;a}=end and {;a}=end{/rest} both match a="end"), only _scan_prefix takes the empty reading first.
Approach I’d take: in _scan_prefix’s ifemp branch, when uri[pos] == "=", try the ;name=value reading first (bounded by the ; stop chars) and fall back to the empty check only if the next literal isn’t found. Prototype is ~15 lines in that one function and passes the existing 307 template tests. Happy to send it if you’d like an outside PR. (Investigated with AI assistance.)
Thanks @media-ctrl, good catch. The stop-char span takes "end=end" and falls back to the wrong parse, so the bounded find to the next literal is the right fix. I'll step back and leave this to @ZYZ666-RGB / you. Happy to review the PR.
Thanks @media-ctrl. I had an earlier fork branch, but it didn't use the bounded find to the next literal, so #3860 is the better fix. I'll close mine out rather than open a duplicate. Please go ahead with #3860.
Thanks for clarifying. I'm still stepping back in favor of #3860. Maintainers, could you review @media-ctrl's bounded-find fix and, if appropriate, assign this issue to them and reopen that PR? I won't open a competing PR.
Activity
ZYZ666-RGB commentedon Nov 13, 2026
I'd like to take this issue and ask to be assigned.
UriTemplate.match()currently misparses{;var}when the following literal starts with=, because the empty-value check in_scan_prefixcan treat that literal as an empty path-style value. I plan to fix that check insrc/mcp/shared/uri_template.pyand add tests somatch(expand(variables)) == variablesholds for this case (including examples like{;a}=end{+rest}).Please assign this issue to me. Once it is assigned, I will open a PR with
Fixes #3852, as described in the contributing guide (external PRs are reviewed when assigned or labeled help wanted).media-ctrl commentedon Nov 14, 2026
shlokbam commentedon Nov 14, 2026
Confirmed on main (77001c9). One nuance: ;a=end=end/x is genuinely ambiguous for {;a}=end{+rest}, since {a: "", rest: "=end/x"} expands to the same string, so the fix is really about consistency: the suffix scan already prefers ;name=value ({;a}=end and {;a}=end{/rest} both match a="end"), only _scan_prefix takes the empty reading first.
Approach I’d take: in _scan_prefix’s ifemp branch, when uri[pos] == "=", try the ;name=value reading first (bounded by the ; stop chars) and fall back to the empty check only if the next literal isn’t found. Prototype is ~15 lines in that one function and passes the existing 307 template tests. Happy to send it if you’d like an outside PR. (Investigated with AI assistance.)
media-ctrl commentedon Nov 14, 2026
shlokbam commentedon Nov 14, 2026
Thanks @media-ctrl, good catch. The stop-char span takes "end=end" and falls back to the wrong parse, so the bounded find to the next literal is the right fix. I'll step back and leave this to @ZYZ666-RGB / you. Happy to review the PR.
media-ctrl commentedon Nov 14, 2026
ZYZ666-RGB commentedon Nov 14, 2026
Thanks @media-ctrl. I had an earlier fork branch, but it didn't use the bounded find to the next literal, so #3860 is the better fix. I'll close mine out rather than open a duplicate. Please go ahead with #3860.
media-ctrl commentedon Nov 14, 2026
ZYZ666-RGB commentedon Nov 15, 2026
Thanks for clarifying. I'm still stepping back in favor of #3860. Maintainers, could you review @media-ctrl's bounded-find fix and, if appropriate, assign this issue to them and reopen that PR? I won't open a competing PR.