Repository navigation
Conversation
ze_lib::debug_trace_message() and the zello_log.h to_*() parsers take std::string by value but never modify it, copying on every call. Take const std::string& instead. Found by Coverity UNNECESSARY_STRING_COPY. Signed-off-by: Krzysztof Filipek <krzysztof.filipek@intel.com>
KFilipek
force-pushed
the
ze-string-by-const-ref
branch
from
November 20, 2026 10:55
95e7d6d to
581673b
Compare
Level Zero loader ABI checklast-release ( master ( If an ABI change is intended, a reviewer with write access can accept it: leave an approval review on the PR head commit with the keyword |
Same change as the previous commit for loader::context_t, including the mako template that generates ze_loader_internal.h. Signed-off-by: Krzysztof Filipek <krzysztof.filipek@intel.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ze_lib::debug_trace_message()and theto_layout(),to_format_type(),to_flag()andto_image_type()parsers inzello_log.htakestd::stringby value but never modify it, so every call copies the string.Take
const std::string &instead. No behavior change; callers are unaffected.Found by Coverity (UNNECESSARY_STRING_COPY).